follow-up

Signed-off-by: Alex Aizman <[email protected]>
NVIDIA · Jan 6, 2025 · 200cb4c · 200cb4c
1 parent d8ae4af
commit 200cb4c
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 9 deletions.
diff --git a/cmd/cli/go.mod b/cmd/cli/go.mod
@@ -3,7 +3,7 @@ module github.com/NVIDIA/aistore/cmd/cli
 go 1.23.2
 
 require (
-	github.com/NVIDIA/aistore v1.3.26-0.20250105213550-2b2694a79519
+	github.com/NVIDIA/aistore v1.3.26-0.20250106161132-d8ae4afc3594
 	github.com/fatih/color v1.18.0
 	github.com/json-iterator/go v1.1.12
 	github.com/onsi/ginkgo/v2 v2.21.0

diff --git a/cmd/cli/go.sum b/cmd/cli/go.sum
@@ -1,7 +1,7 @@
 code.cloudfoundry.org/bytefmt v0.0.0-20190710193110-1eb035ffe2b6/go.mod h1:wN/zk7mhREp/oviagqUXY3EwuHhWyOvAdsn5Y4CzOrc=
 github.com/BurntSushi/toml v1.4.0/go.mod h1:ukJfTF/6rtPPRCnwkur4qwRxa8vTRFBF0uk2lLoLwho=
-github.com/NVIDIA/aistore v1.3.26-0.20250105213550-2b2694a79519 h1:4HbBsL5+pd3cv0awBbyxdwfTps8/lSMQujqvhY5eI0s=
-github.com/NVIDIA/aistore v1.3.26-0.20250105213550-2b2694a79519/go.mod h1:mjhY9OGIZULaC79+iRfzEUvUZw7aIWklJ8um321QVpw=
+github.com/NVIDIA/aistore v1.3.26-0.20250106161132-d8ae4afc3594 h1:Qn1yaBunXuJOSSIC82e9o2YrPi932T8zmlpZmn5hWPU=
+github.com/NVIDIA/aistore v1.3.26-0.20250106161132-d8ae4afc3594/go.mod h1:mjhY9OGIZULaC79+iRfzEUvUZw7aIWklJ8um321QVpw=
 github.com/OneOfOne/xxhash v1.2.8 h1:31czK/TI9sNkxIKfaUfGlU47BAxQ0ztGgd9vPyqimf8=
 github.com/OneOfOne/xxhash v1.2.8/go.mod h1:eZbhyaAYD41SGSSsnmcpxVoRiQ/MPUTjUdIIOT9Um7Q=
 github.com/VividCortex/ewma v1.1.1/go.mod h1:2Tkkvm3sRDVXaiyucHiACn4cqf7DpdyLvmxzcbUokwA=

diff --git a/cmd/ishard/go.mod b/cmd/ishard/go.mod
@@ -3,7 +3,7 @@ module github.com/NVIDIA/aistore/cmd/ishard
 go 1.23.2
 
 require (
-	github.com/NVIDIA/aistore v1.3.26-0.20250105213550-2b2694a79519
+	github.com/NVIDIA/aistore v1.3.26-0.20250106161132-d8ae4afc3594
 	github.com/json-iterator/go v1.1.12
 	github.com/vbauerster/mpb/v4 v4.12.2
 )

diff --git a/cmd/ishard/go.sum b/cmd/ishard/go.sum
@@ -1,6 +1,6 @@
 code.cloudfoundry.org/bytefmt v0.0.0-20190710193110-1eb035ffe2b6/go.mod h1:wN/zk7mhREp/oviagqUXY3EwuHhWyOvAdsn5Y4CzOrc=
-github.com/NVIDIA/aistore v1.3.26-0.20250105213550-2b2694a79519 h1:4HbBsL5+pd3cv0awBbyxdwfTps8/lSMQujqvhY5eI0s=
-github.com/NVIDIA/aistore v1.3.26-0.20250105213550-2b2694a79519/go.mod h1:mjhY9OGIZULaC79+iRfzEUvUZw7aIWklJ8um321QVpw=
+github.com/NVIDIA/aistore v1.3.26-0.20250106161132-d8ae4afc3594 h1:Qn1yaBunXuJOSSIC82e9o2YrPi932T8zmlpZmn5hWPU=
+github.com/NVIDIA/aistore v1.3.26-0.20250106161132-d8ae4afc3594/go.mod h1:mjhY9OGIZULaC79+iRfzEUvUZw7aIWklJ8um321QVpw=
 github.com/OneOfOne/xxhash v1.2.8 h1:31czK/TI9sNkxIKfaUfGlU47BAxQ0ztGgd9vPyqimf8=
 github.com/OneOfOne/xxhash v1.2.8/go.mod h1:eZbhyaAYD41SGSSsnmcpxVoRiQ/MPUTjUdIIOT9Um7Q=
 github.com/VividCortex/ewma v1.1.1 h1:MnEK4VOv6n0RSY4vtRe3h11qjxL3+t0B8yOL8iMXdcM=

diff --git a/cmd/ishard/ishard/ishard_test.go b/cmd/ishard/ishard/ishard_test.go
@@ -818,7 +818,7 @@ func generateNestedStructure(baseParams api.BaseParams, bucket cmn.Bck, numRecor
 		}
 	}
 
-	fmt.Printf("generated %d records in %s bucket\n", numRecords, bucket)
+	fmt.Printf("generated %d records in %s bucket\n", numRecords, bucket.String())
 	return totalSize, nil
 }
 

diff --git a/cmn/cos/fs_unix.go b/cmn/cos/fs_unix.go
@@ -1,13 +1,13 @@
 // Package cos provides common low-level types and utilities for all aistore projects
 /*
- * Copyright (c) 2018-2024, NVIDIA CORPORATION. All rights reserved.
+ * Copyright (c) 2018-2025, NVIDIA CORPORATION. All rights reserved.
  */
 package cos
 
 import "syscall"
 
 type FS struct {
-	Fs     string
+	Fs     string // usually, a block device (or its partition) formatted with a given filesystem (e.g., xfs)
 	FsType string
 	FsID   FsID
 }

diff --git a/fs/fs.go b/fs/fs.go
@@ -151,6 +151,7 @@ func (mi *Mountpath) String() string {
 	if mi.info == "" {
 		switch len(mi.Disks) {
 		case 0:
+			// where `fs=` is a block device (or its partition) formatted with a given filesystem (e.g., xfs)
 			mi.info = fmt.Sprintf("mp[%s, fs=%s%s]", mi.Path, mi.Fs, s)
 		case 1:
 			mi.info = fmt.Sprintf("mp[%s, %s%s]", mi.Path, mi.Disks[0], s)
-Original file line number
+Diff line change
@@ Expand Up @@
     		}
     	}
-    	fmt.Printf("generated %d records in %s bucket\n", numRecords, bucket)
+    	fmt.Printf("generated %d records in %s bucket\n", numRecords, bucket.String())
     	return totalSize, nil
     }
@@ Expand Down @@