Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Flagship Pioneering protein inverse folding model (RLDIF) into bionemo #212

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

yashaektefaie
Copy link
Collaborator

@yashaektefaie yashaektefaie commented Sep 28, 2024

In the "sub-packages" directory I have added a directory called "bionemo-rldif.” In this directory is the code to run a protein inverse folding model developed by Flagship Pioneering. I added a src and test sub-directory following the structure of other projects in the "sub-packages" directory and tested this code locally and confirmed it works. Ideally users can use this code to import rldif and run our developed inverse folding model for their protein structures.

Usage

The intended usage of the code can be seen in the README of the bionemo-rldif directory. From what I saw from other packages, pip-installing the model and then importing it was the preferred usage so adapted the code to accommodate for that.

Testing

Since I don't have the AWS credentials needed to build the Docker container and the required torch-scatter package version conflicts with the PyTorch version installed by bionemo-core, I wasn't able to test the code in Docker. However, I successfully ran the test by moving the test file from the test directory to the src directory and executing:

python3 -m bionemo.rldif.test_run

This test confirms the model can generate reasonable sequences from a given pdb file, validating the core functionality.

I did review this document, as stated earlier due to this AWS credential issue most of what is on there I cannot run apart from the code etiquette portion which I also left alone for now because I was not sure if that applied to this project since it is supposed to be used in a straightforward manner for model inference. If it does apply feel free to point this out and I'll comment all relevant code and functions.

  • Did you make sure your changes have tests? Did you test your changes locally?

Yes, please see my response to the earlier question.

Given I was not able to test the CI cannot put this label.

Given I was not able to run the PYTEST beyond the way I described, I cannot put this label.

I also cannot put this label.

@yashaektefaie yashaektefaie changed the title Integrating Flagship Pioneering protein inverse folding model into bionemo Integrating Flagship Pioneering protein inverse folding model (RLDIF) into bionemo Sep 28, 2024
@jstjohn
Copy link
Collaborator

jstjohn commented Oct 4, 2024

/build-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants