add global conftest and error on unfreed cuda tensors #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sub-packages/conftest.py
Outdated
Comment on lines
35
to
36
| if raise_on_cuda_tensor: | ||
| raise AssertionError(f"Found a CUDA tensor in memory after test: {obj_str}") |
There was a problem hiding this comment.
Deleting the string representation of the data won't actually delete the underlying data. You have to somehow get a reference to the underlying data and free that. Ofc. if there are any other references to the data, that'd setup a potential use-after-free error. So what you'd really want to do is gather all references and delete those, then let the GC free the underlying memory after observing no more references to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new module-level fixture for cleaning up cuda artifacts, and moves all existing pytest fixtures to the function scope.