Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MoCo Version and MDLM params #632

Merged
merged 18 commits into from
Jan 29, 2025

Conversation

nvdreidenbach
Copy link
Collaborator

Update Version and MDLM options. Also remove duplicate files

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.68%. Comparing base (42d76aa) to head (376dc89).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...moco/interpolants/discrete_time/continuous/ddpm.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
+ Coverage   86.62%   86.68%   +0.05%     
==========================================
  Files         116      117       +1     
  Lines        6961     7014      +53     
==========================================
+ Hits         6030     6080      +50     
- Misses        931      934       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Danny <[email protected]>
Signed-off-by: Danny <[email protected]>
Signed-off-by: Danny <[email protected]>
Signed-off-by: Danny <[email protected]>
Signed-off-by: Danny <[email protected]>
Signed-off-by: Danny <[email protected]>
Signed-off-by: Danny <[email protected]>
Copy link
Collaborator

@pstjohn pstjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have a mkdocs page that builds some of this API documentation; might be worth trying to integrate that into the docs at some point?

Signed-off-by: Danny <[email protected]>
@jstjohn jstjohn added the INCLUDE_NOTEBOOKS_TESTS Add Jupyter notebook validation to the CI pipeline label Jan 28, 2025
Copy link
Collaborator

@jstjohn jstjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but added the notebook tests flag since you have changes to notebooks.

@nvdreidenbach nvdreidenbach added this pull request to the merge queue Jan 29, 2025
Merged via the queue into NVIDIA:main with commit cf3652a Jan 29, 2025
11 checks passed
@nvdreidenbach nvdreidenbach deleted the dreidenbach/moco_update branch January 29, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INCLUDE_NOTEBOOKS_TESTS Add Jupyter notebook validation to the CI pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants