Changes to SCDL and documentation #643
Merged
+105
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Polina Binder <[email protected]>
Signed-off-by: Polina Binder <[email protected]>
Signed-off-by: Polina Binder <[email protected]>
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
- Coverage 86.68% 86.65% -0.03%
==========================================
Files 117 117
Lines 7014 7021 +7
==========================================
+ Hits 6080 6084 +4
- Misses 934 937 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Polina Binder <[email protected]>
Signed-off-by: Polina Binder <[email protected]>
polinabinder1
requested review from
jstjohn,
malcolmgreaves,
skothenhill-nv,
dorotat-nv,
pstjohn,
trvachov and
jwilber
as code owners
Signed-off-by: polinabinder1 <[email protected]>
trvachov
reviewed
Jan 27, 2025
trvachov
reviewed
Jan 27, 2025
trvachov
approved these changes
Jan 27, 2025
trvachov
requested changes
Jan 27, 2025
Signed-off-by: Polina Binder <[email protected]>
Signed-off-by: Polina Binder <[email protected]>
|
Could you fill out the PR description? Theyre useful for referencing changes in the future. |
sub-packages/bionemo-scdl/src/bionemo/scdl/io/single_cell_memmap_dataset.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-scdl/tests/bionemo/scdl/index/test_row_feature_index.py
Show resolved
Hide resolved
skothenhill-nv
approved these changes
Jan 28, 2025
trvachov
approved these changes
Jan 29, 2025
Signed-off-by: Polina Binder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some additional documentation around run time and memory usage profiling. Additionally, the code now handles missing feature ids, either by setting them to be the row indices, or by setting an empty row feature index.