Skip to content

Migrate to windows-2022 for Windows CI builds #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

cryos
Copy link
Collaborator

@cryos cryos commented Jun 2, 2025

Description

Update the base image for the Windows-based CI builds from windows-2019 to windows-2022, closes #665.

The windows-2019 image has been deprecated and will be removed at the end of June 2025. Move to windows-2022 and verify everything builds as expected.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link
Contributor

copy-pr-bot bot commented Jun 2, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cryos
Copy link
Collaborator Author

cryos commented Jun 2, 2025

/ok to test

@cryos cryos linked an issue Jun 2, 2025 that may be closed by this pull request
@cryos cryos added the CI/CD CI/CD infrastructure label Jun 2, 2025
@cryos cryos self-assigned this Jun 2, 2025

This comment has been minimized.

@cryos cryos marked this pull request as ready for review June 2, 2025 18:41
Copy link
Contributor

copy-pr-bot bot commented Jun 2, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cryos cryos requested a review from leofang June 2, 2025 19:13
@leofang leofang added the P0 High priority - Must do! label Jun 4, 2025
@leofang leofang added this to the cuda.core beta 4 milestone Jun 4, 2025
@leofang leofang mentioned this pull request Jun 4, 2025
2 tasks
@leofang leofang added the packaging Anything related to wheels or Conda packages label Jun 4, 2025
@kkraus14
Copy link
Collaborator

kkraus14 commented Jun 4, 2025

/ok to test

@kkraus14 kkraus14 merged commit e75b3ac into NVIDIA:main Jun 4, 2025
53 checks passed
Copy link

github-actions bot commented Jun 4, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD infrastructure P0 High priority - Must do! packaging Anything related to wheels or Conda packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Move away from using the windows-2019 image
3 participants