Skip to content

Use cuda::stream_ref in Python stream shims #23694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vyasr wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −7
Draft

Use cuda::stream_ref in Python stream shims #23694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6769c4
Use cuda::stream_ref in Python stream shims
vyasr Aug 17, 2026
1b03abe
Use cuda stream header in Python shims
vyasr Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions python/cudf/udf_cpp/strings/src/strings/udf/udf_apis.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2022-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-License-Identifier: Apache-2.0
*/

Expand Down Expand Up @@ -48,7 +48,7 @@ struct managed_udf_string_to_string_view_transform_fn {
* @param stream CUDA stream used for allocating/copying device memory and launching kernels
*/
std::unique_ptr<rmm::device_buffer> to_string_view_array(cudf::column_view const input,
rmm::cuda_stream_view stream)
cuda::stream_ref stream)
{
return std::make_unique<rmm::device_buffer>(
std::move(cudf::strings::create_string_vector_from_column(
Expand All @@ -62,7 +62,7 @@ std::unique_ptr<rmm::device_buffer> to_string_view_array(cudf::column_view const
* @param stream CUDA stream used for allocating/copying device memory and launching kernels
*/
std::unique_ptr<cudf::column> column_from_managed_udf_string_array(
managed_udf_string* managed_strings, cudf::size_type size, rmm::cuda_stream_view stream)
managed_udf_string* managed_strings, cudf::size_type size, cuda::stream_ref stream)
{
// create string_views of the udf_strings
auto indices = rmm::device_uvector<cudf::string_view>(size, stream);
Expand All @@ -73,7 +73,7 @@ std::unique_ptr<cudf::column> column_from_managed_udf_string_array(
managed_udf_string_to_string_view_transform_fn{});

auto result = cudf::make_strings_column(indices, cudf::string_view(nullptr, 0), stream);
stream.synchronize();
stream.sync();
return result;
}

Expand Down
6 changes: 3 additions & 3 deletions python/pylibcudf/pylibcudf/libcudf/detail/utilities/stream_pool.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0

from cuda.bindings.cyruntime cimport cudaStream_t
Expand All @@ -12,15 +12,15 @@ cdef extern from * nogil:
"""
#include <cudf/detail/utilities/stream_pool.hpp>
#include <cudf/utilities/span.hpp>
#include <rmm/cuda_stream_view.hpp>
#include <cuda/stream>
#include <vector>

namespace {
void join_streams_wrapper(
cudf::host_span<cudaStream_t const> streams,
cudaStream_t stream
) {
std::vector<rmm::cuda_stream_view> stream_views(streams.begin(), streams.end());
std::vector<cuda::stream_ref> stream_views(streams.begin(), streams.end());
cudf::detail::join_streams(stream_views, stream);
}
}
Expand Down
Loading