-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add cuDF Java Maven Central publish job #23714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
paul-aiyedun
wants to merge
9
commits into
NVIDIA:main
Choose a base branch
from
paul-aiyedun:paul/java_maven_central_publish
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f781433
Add cuDF Java Maven Central publish job
paul-aiyedun db96474
TEMPORARY: CI release validation test
paul-aiyedun e7746fe
TEMPORARY: CI release validation test
paul-aiyedun 29c8680
Revert "TEMPORARY: CI release validation test"
paul-aiyedun 88feafb
Revert "TEMPORARY: CI release validation test"
paul-aiyedun 3615fcc
Merge branch 'main' into paul/java_maven_central_publish
paul-aiyedun 06dc96e
Address CodeRabbit comments
paul-aiyedun 3a1e82f
Merge branch 'main' into paul/java_maven_central_publish
paul-aiyedun c3f3705
Add mv error handling and update README
paul-aiyedun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: NVIDIA/cudf
Length of output: 4681
🏁 Script executed:
Repository: NVIDIA/cudf
Length of output: 50368
🌐 Web query:
rapidsai gha-tools rapids-is-release-build implementation GITHUB_REF tag vYY.MM.PP💡 Result:
The rapids-is-release-build tool is a bash script provided by the rapidsai/gha-tools repository, which contains reusable shell scripts and GitHub Actions tools for RAPIDS CI/CD workflows [1][2]. It is used to programmatically determine whether the current CI/CD environment is running a release build [3]. Implementation and Logic While the specific source code for rapids-is-release-build is not explicitly quoted in the provided results, the tool is designed to inspect environment variables, typically GITHUB_REF, to identify if a workflow run corresponds to a release [3][4]. In the context of RAPIDS CI/CD: 1. Identification: It checks if the GITHUB_REF matches a release tag format, generally following vYY.MM.PP (e.g., v26.08.00) [4][5]. 2. Purpose: The tool is primarily used within automation scripts, such as conda upload workflows, to toggle between release and nightly credentials or repository channels [3]. For instance, if rapids-is-release-build returns true, a workflow will use production secrets (like CONDA_RAPIDSAI_TOKEN) instead of nightly ones [3]. Context in Workflows - Automation: It is utilized in shared GitHub Actions workflows, such as conda-upload-packages.yaml, to dynamically configure upload destinations [3]. - Branching Strategy: RAPIDS CI/CD distinguishes between different run contexts. When a release build is detected (often via tag or specific release branch), the pipeline proceeds with formal release procedures (e.g., publishing to official channels), whereas pull request builds or nightlies are handled separately [2][3][6]. To use or integrate these tools, repositories typically clone the rapidsai/gha-tools repository during the workflow setup and add the /tools directory to the system PATH [1][7].
Citations:
🏁 Script executed:
Repository: NVIDIA/cudf
Length of output: 7797
Gate
java-publishon the release-tag contract.The
pushtrigger filters tags tovYY.MM.PP, butworkflow_dispatchaccepts any ref. A manual run on any tag withbuild_type: branchsatisfies this condition. Gate publishing on the release predicate or ongithub.event_name == 'push'with the release-tag filter.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdice @vyasr What do you think about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused. I see nightlies are marked as a TODO. But how do we do meaningful tests in #23732 without publishing a build from every run of
build.yaml?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TODO item here is nightly publication to Sonatype (this is like the nightly publication to Conda). We already generate nightly cuda-java builds (e.g. https://github.com/NVIDIA/cudf/actions/runs/32362518083/job/96405026575). The
java-publishjob is specifically about publishing to Maven Central (official releases) or Sonatype Snapshots Repo (nightly snapshots).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question here is about the best gate for release-only execution of the job (until Sonatype nightly snapshot support is added).