chore(core): cover duplicate package version audit log - #227
Merged
coryrylan merged 1 commit intoAug 19, 2026
Conversation
Adds a unit test for getDuplicatePackageVersionWarning, raising audit-logs.ts line coverage from 88.88% to 100%. No behavior change. Signed-off-by: Cursor Agent <cursoragent@cursor.com>
cursor
Bot
force-pushed
the
upkeep/coverage/audit-logs-duplicate-version-warning
branch
from
August 19, 2026 06:24
d6b44f1 to
7b29666
Compare
coryrylan
marked this pull request as ready for review
August 19, 2026 13:45
coryrylan
self-requested a review
August 19, 2026 13:45
coryrylan
approved these changes
Aug 19, 2026
coryrylan
deleted the
upkeep/coverage/audit-logs-duplicate-version-warning
branch
August 19, 2026 13:46
Collaborator
|
🎉 This issue has been resolved in version 2.3.2 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 2.0.1 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 2.1.3 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upkeep
Task: coverage
Target:
projects/core/src/internal/utils/audit-logs.tsRationale: "1 uncovered lines, 88.88% lines and 100% branches, the smallest gap below the 90% threshold"
Measurement
Added a unit test for
getDuplicatePackageVersionWarning, the only uncovered helper in the file.Guarantees
Left alone
audit-logs.tssourceVerification
projects/core: lint, test, test:types, test:axe, test:ssr, test:lighthouse, test:visual — passedpnpm run cistill failsstylestypography visuals underCI=true(font glyph drift vs committed baselines); GitHubcionmainis green for the same tests — baselines not rewritten