chore(cli): remove unnecessary boolean conversion in isInteractiveTerminal - #228
Merged
Merged
Conversation
…minal Replace Boolean(stream.isTTY) with stream.isTTY directly, fixing the last @typescript-eslint/no-unnecessary-type-conversion suppression in utils.ts. Pruned the cli eslint-suppressions entry (1 -> 0). Signed-off-by: Cursor Agent <cursoragent@cursor.com>
coryrylan
approved these changes
Aug 20, 2026
Collaborator
|
🎉 This issue has been resolved in version 2.3.2 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 2.0.1 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 2.1.3 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Lint (Mode B) — burn down one
@typescript-eslint/no-unnecessary-type-conversionsuppression.Rationale (from selector):
@typescript-eslint/no-unnecessary-type-conversionis enforced with 1 suppressed violation left in this file, the smallest remaining group. 9 suppressions remain across the repository.Change
In
isInteractiveTerminal, replacedBoolean(stream.isTTY)withstream.isTTYdirectly. ESLint flagged the wrapper as an unnecessary type conversion becausestream.isTTYis already boolean when defined.Before / After
@typescript-eslint/no-unnecessary-type-conversionsuppressions inprojects/cli/eslint-suppressions.jsonVerification
pnpm run lint,pnpm run testinprojects/cli— passpnpm run ci— passPublic API
No public API changed.
Left alone
@typescript-eslint/no-unnecessary-type-conversionsuppressions in core, forms, and media (8 remaining repo-wide)