fix(ci): stabilize monaco worker bundle lighthouse checks - #229
Merged
Conversation
Remove simulated performance score assertions from monaco input and diff-input worker bundle lighthouse tests. Those cases load five editor instances to verify bundle limits and are flaky on ci runners while the single-instance tests still enforce performance benchmarks. Increase lighthouse test retries from 1 to 2 to match other flaky test suites such as visual and axe. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Cory Rylan <coryrylan@users.noreply.github.com>
coryrylan
self-requested a review
August 20, 2026 18:53
coryrylan
marked this pull request as ready for review
August 20, 2026 18:53
johnyanarella
self-requested a review
August 20, 2026 20:28
johnyanarella
approved these changes
Aug 20, 2026
| </script> | ||
| `); | ||
|
|
||
| expect(report.scores.performance).toBeGreaterThanOrEqual(90); |
Collaborator
There was a problem hiding this comment.
Agree these are fair to remove. The earlier test asserts performance, where these tests and their fixtures are specifically intended for asserting worker bundle sizes.
coryrylan
approved these changes
Aug 21, 2026
Collaborator
|
🎉 This issue has been resolved in version 2.3.2 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 2.0.1 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 2.1.3 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed run
993cd55e63160b876629539ced739dd6fc487433lighthouseFirst causal error
The retry also scored 86, so the existing
retry: 1configuration did not recover.Root cause
The
monaco-diff-input language worker bundleslighthouse test loads five Monaco diff-input instances (plaintext, css, html, json, typescript) to verify combined language worker bundle sizes. Simulated Lighthouse performance scores on this stress-test page are variable on CI runners (88/86 on the failed run) while bundle-size assertions remain stable.The triggering commit (
chore(cli): remove unnecessary boolean conversion in isInteractiveTerminal) did not touch Monaco; the previous main CI run at4d93214dpassed the lighthouse job. This is an intermittent repository-owned flake in the worker-bundle lighthouse cases, not an infrastructure outage.Fix
performance >= 90, and the worker-bundle tests continue to assert accessibility, best practices, and bundle size limits.1to2, matching visual and axe suites.Validation
Remaining risk
Full root
pnpm run lighthousewas not run locally due to time; the failing suite was reproduced and validated in isolation. Other lighthouse suites may still flake on performance scores under CI load, but this change targets the exact failure signature from run 32377701213.