Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logic for including the IMEX nodes_config.cfg file in GFD #1318

Merged
merged 4 commits into from
Mar 11, 2025
Merged

Remove logic for including the IMEX nodes_config.cfg file in GFD #1318

merged 4 commits into from
Mar 11, 2025

Conversation

cdesiniotis
Copy link
Contributor

GFD no longer adds the nvidia.com/gpu.imex-domain label, and thus the logic to make the IMEX config file, nodes_config.cfg, available to GFD is no longer needed.

See NVIDIA/k8s-device-plugin@90c0589

@cdesiniotis cdesiniotis requested a review from klueska March 9, 2025 18:48
@cdesiniotis cdesiniotis requested a review from guptaNswati March 9, 2025 18:50
@cdesiniotis cdesiniotis force-pushed the gfd-remove-imex-domain-label branch from 5e7f3ed to 1eaafc0 Compare March 9, 2025 18:53
@tariq1890
Copy link
Contributor

Let's limit this PR to revert commits and open a new one for the [gfd] only mount /run/nvidia/validations in init container commit

@cdesiniotis cdesiniotis force-pushed the gfd-remove-imex-domain-label branch 2 times, most recently from b97832e to 3ff960c Compare March 10, 2025 18:29
@cdesiniotis
Copy link
Contributor Author

Let's limit this PR to revert commits and open a new one for the [gfd] only mount /run/nvidia/validations in init container commit

I have removed [gfd] only mount /run/nvidia/validations in init container and will raise a follow-up for it.

@guptaNswati
Copy link
Contributor

guptaNswati commented Mar 10, 2025 •
edited
Loading

Let's limit this PR to revert commits and open a new one for the [gfd] only mount /run/nvidia/validations in init container commit

I have removed [gfd] only mount /run/nvidia/validations in init container and will raise a follow-up for it.

+1 to this.

So, this is a revert of these 2 PRS?
https://github.com/NVIDIA/gpu-operator/pull/1055/files
#1070

@cdesiniotis
Copy link
Contributor Author

So, this is a revert of these 2 PRS?
https://github.com/NVIDIA/gpu-operator/pull/1055/files
#1070

Correct.

@cdesiniotis cdesiniotis force-pushed the gfd-remove-imex-domain-label branch from 3ff960c to 95ca738 Compare March 10, 2025 18:53
@guptaNswati
Copy link
Contributor

LGTM. Once all the checks are passed. Its G2G in

@cdesiniotis cdesiniotis enabled auto-merge March 10, 2025 19:13
@cdesiniotis cdesiniotis force-pushed the gfd-remove-imex-domain-label branch from d11d9ac to 284ee31 Compare March 11, 2025 17:43
@cdesiniotis
Copy link
Contributor Author

cdesiniotis commented Mar 11, 2025 •
edited
Loading

I have updated this PR to also revert b82b91b which I missed.

@cdesiniotis
Revert "Always add 'config' emptyDir volume to GFD and device-plugin …
2502b7b 
…daemonsets"

This reverts commit 22941b5.

Signed-off-by: Christopher Desiniotis <[email protected]>
@cdesiniotis
Revert "Add init container to GFD for handling imex nodes config mount"
b6747d6 
This reverts commit a076f89.

Signed-off-by: Christopher Desiniotis <[email protected]>
@cdesiniotis
Revert "Make the IMEX nodes config file available to GFD"
0a6f1f2 
This reverts commit 5525636.

Signed-off-by: Christopher Desiniotis <[email protected]>
@cdesiniotis
Revert "Always add 'config' emptyDir volume to MPS daemonset"
8c4b19d 
This reverts commit b82b91b.

Signed-off-by: Christopher Desiniotis <[email protected]>
@cdesiniotis cdesiniotis force-pushed the gfd-remove-imex-domain-label branch from 284ee31 to 8c4b19d Compare March 11, 2025 17:47
@cdesiniotis cdesiniotis merged commit 987464e into main Mar 11, 2025
15 checks passed
@tariq1890 tariq1890 deleted the gfd-remove-imex-domain-label branch March 11, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guptaNswati guptaNswati guptaNswati left review comments

@tariq1890 tariq1890 tariq1890 approved these changes

@klueska klueska Awaiting requested review from klueska

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

@elezar elezar Awaiting requested review from elezar elezar is a code owner

@shivamerla shivamerla Awaiting requested review from shivamerla shivamerla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdesiniotis @tariq1890 @guptaNswati