Skip to content

Conversation

sinanmohd
Copy link

@sinanmohd sinanmohd commented Sep 10, 2025

fixes nvidia-validator on NixOS, TALOS, etc...

tested on NixOS with k3s and

helm install --wait --generate-name \
    -n gpu-operator --create-namespace \
    nvidia/gpu-operator \
    --version=v25.3.0 \
    --set driver.enabled=false \
    --set toolkit.env[0].name=CONTAINERD_CONFIG \
    --set toolkit.env[0].value=/var/lib/rancher/k3s/agent/etc/containerd/config.toml \
    --set toolkit.env[1].name=CONTAINERD_SOCKET \
    --set toolkit.env[1].value=/run/k3s/containerd/containerd.sock \

replaced the validator image with k9s edit, built the binary using

FROM golang:1.24.3
COPY ./ /app
WORKDIR /app
RUN go build ./cmd/nvidia-validator/
FROM  nvcr.io/nvidia/cloud-native/gpu-operator-validator:v25.3.0
COPY --from=0 /app/nvidia-validator /usr/bin/nvidia-validator

Closes: #1687

Copy link

copy-pr-bot bot commented Sep 10, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@sinanmohd sinanmohd changed the title fix(nvidia-validator): don't leak PATH from nvidia-validator containe… fix(nvidia-validator): don't leak PATH from nvidia-validator container to chroot env Sep 10, 2025
@sinanmohd sinanmohd changed the title fix(nvidia-validator): don't leak PATH from nvidia-validator container to chroot env fix(nvidia-validator): don't leak PATH from container to chroot env Sep 10, 2025
@sinanmohd sinanmohd force-pushed the main branch 2 times, most recently from 560cb2f to 9e6f407 Compare September 10, 2025 08:27
@sinanmohd sinanmohd marked this pull request as ready for review September 10, 2025 08:50
@sinanmohd sinanmohd marked this pull request as draft September 10, 2025 10:58
@sinanmohd sinanmohd marked this pull request as ready for review September 10, 2025 13:19
@elezar elezar removed their request for review October 15, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nvidia-validator failed in Talos

1 participant