Add permissions for nodefeatures in GFD's role object #1775
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdesiniotis
requested review from
ArangoGutierrez,
elezar,
shivamerla and
tariq1890
as code owners
tariq1890
previously approved these changes
Oct 10, 2025
|
I just realized this is not sufficient. We will also have to add these permissions to the gpu-operator cluster role as well -- otherwise it won't be able to create the GFD cluster role. |
These permissions are required when GFD is configured to use the Node Feature API instead of feature files. Signed-off-by: Christopher Desiniotis <[email protected]>
cdesiniotis
force-pushed
the
gfd-clusterperms-for-node-features
branch
from
1695c5b to
2a419fc
Compare
cdesiniotis
changed the title
|
I realized that NodeFeatures are a namespaced resource. I have moved the permissions to the role objects for gpu-operator and GFD respectively. |
tariq1890
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These permissions are required when GFD is configured to use the Node Feature API instead of feature files.