Skip to content

fix(ci): Don't make lint-police a prereq of test-release-container-se…#2971

Merged
kensimon merged 2 commits into
NVIDIA:mainfrom
kensimon:lint-police-parallel-again
Jun 29, 2026
Merged

fix(ci): Don't make lint-police a prereq of test-release-container-se…#2971
kensimon merged 2 commits into
NVIDIA:mainfrom
kensimon:lint-police-parallel-again

Conversation

@kensimon

Copy link
Copy Markdown
Contributor

…rvices

The lint-police check ends up running an individual build of every crate as part of a check that ensures the crates build individually and not just as a workspace... its cost was justified by the fact that it was supposed to run in parallel with the test-release-container-services check, but I inadvertently added this dependency which prevents them running in parallel. This undoes that.

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Thanks @poroh for pointing out the regression here

…rvices

The lint-police check ends up running an individual build of every crate
as part of a check that ensures the crates build individually and not
just as a workspace... its cost was justified by the fact that it was
supposed to run in parallel with the test-release-container-services
check, but I inadvertently added this dependency which prevents them
running in parallel. This undoes that.
@kensimon kensimon requested a review from a team as a code owner June 29, 2026 16:02
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 97e8f1a8-8e07-4788-8c8e-a300ae80bc13

📥 Commits

Reviewing files that changed from the base of the PR and between 6c101fe and 93fbc8a.

📒 Files selected for processing (1)
  • .github/workflows/ci.yaml
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yaml

Summary by CodeRabbit

  • Chores
    • Updated the automated release/testing workflow so release container build and service test jobs no longer depend on an unrelated check, improving pipeline execution flow and reducing unnecessary blocking.

Walkthrough

The CI workflow removes lint-police from the gating and dependency checks for build-release-container-aarch64 and test-release-container-services.

Changes

CI Dependency Graph Update

Layer / File(s) Summary
Update release job gating
.github/workflows/ci.yaml
Removes lint-police from the needs lists and if conditions of build-release-container-aarch64 and test-release-container-services.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the CI dependency removal affecting lint-police and the release container workflow.
Description check ✅ Passed The description is directly related to the workflow dependency fix and explains the parallelism regression clearly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🔍 Container Scan Summary

Service Total Critical High Medium Low Other
boot-artifacts-aarch64 3 0 0 3 0 0
boot-artifacts-x86_64 3 0 0 3 0 0
forge-admin-cli-x86_64 288 6 26 105 7 144
machine-validation-runner 751 30 190 274 36 221
machine_validation 751 30 190 274 36 221
machine_validation-aarch64 751 30 190 274 36 221
nvmetal-carbide 751 30 190 274 36 221
TOTAL 3298 126 786 1207 151 1028

Per-CVE detail lives in the per-service grype-* artifacts (JSON + SARIF). Severity counts only — no CVE IDs published here.

@nv-dmendoza nv-dmendoza left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kensimon kensimon merged commit ea3a393 into NVIDIA:main Jun 29, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants