Add simple fix for MSVC name mangling #151
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if I am the only person who encounters this, but when I use Jitify in my project (https://github.com/projectchrono/DEM-Engine), on Windows with MSVC, the jit-ed kernel name mangling was never right, until I added this basically one-line fix. I hope my fix can be incorporated, but if the problem was due to the fact that I incorrectly used Jitify on Windows, kindly let me know, too.
Platform compatibility improvement:
type_reflectionstruct injitify.hppto usetypeid(...).name()directly on MSVC, while retaining the use ofdemangle_native_typefor other platforms. This addresses differences in how type names are handled between compilers.