Switch to distroless golang image #1291
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdesiniotis
reviewed
Jun 19, 2025
| @@ -90,7 +87,6 @@ $(IMAGE_TARGETS): image-%: | |||
| .PHONY: build | |||
| build: $(DEFAULT_PUSH_TARGET) | |||
| $(DEFAULT_PUSH_TARGET): build-$(DEFAULT_PUSH_TARGET) | |||
| $(DEFAULT_PUSH_TARGET): DIST = $(DEFAULT_PUSH_TARGET) | |||
There was a problem hiding this comment.
I noticed the following image was pushed via the GitHub Actions: ghcr.io/nvidia/k8s-device-plugin:0ea49e43-. The culprit is likely the IMAGE_TAG variable defined on line 32:
IMAGE_TAG ?= $(IMAGE_VERSION)-$(DIST)
There was a problem hiding this comment.
Good catch. I was rushing this a bit.
elezar
force-pushed
the
switch-to-distroless
branch
from
0ea49e4 to
c771bee
Compare
This also removes the cleanup scripts. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
switch-to-distroless
branch
from
c771bee to
cafbdd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the cleanup scripts.