add ngc signing job for auto signing #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
previously approved these changes
Jul 9, 2024
shivakunv
force-pushed
the
ngc_signing_job
branch
2 times, most recently
from
ad1091b to
cea19ab
Compare
elezar
reviewed
Jul 11, 2024
.nvidia-ci.yml
Outdated
| parallel: | ||
| matrix: | ||
| - SIGN_JOB_NAME: [""] | ||
| DIST: ["", "ubi8"] |
There was a problem hiding this comment.
I would rather stick to "CI_COMMIT_TAG" here. There are projects where "" has a different meaing to CI_COMMIT_TAG and I would like the two to remain consistent.
There was a problem hiding this comment.
@elezar modified
shivakunv
force-pushed
the
ngc_signing_job
branch
from
6ef5bb1 to
7ce6013
Compare
cdesiniotis
approved these changes
Jul 15, 2024
|
@shivakunv can you squash your commits? |
shivakunv
force-pushed
the
ngc_signing_job
branch
5 times, most recently
from
914faa4 to
d57e150
Compare
shivakunv
force-pushed
the
ngc_signing_job
branch
from
03c36fb to
cbb8060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ngc signing job for auto signing
@cdesiniotis @elezar
successfull pipelines: https://gitlab-master.nvidia.com/dl/container-dev/k8s-driver-manager/-/merge_requests/3