feat: annotate generated resources with l8k version - #170
Conversation
Greptile SummaryThe PR propagates centralized Launch Kit build metadata through generation and deployment so generated Kubernetes objects and Helm-rendered resources receive a version annotation while preserving existing annotations.
Confidence Score: 4/5The PR is not yet safe to merge because tagged release images still embed the fallback version and consequently stamp generated and deployed resources with incorrect release metadata. The release-image workflow does not pass the Git tag into the Docker build, so Files Needing Attention: Dockerfile, Makefile, and .github/workflows/image-push-release.yml Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
V[Build-time cmd.Version] --> C[CLI command options]
C --> H[Host target requests]
H --> P[Network Operator plugin]
P --> G[Generated manifest annotator]
P --> R[Helm post-renderer]
G --> Y[Version-annotated YAML resources]
R --> K[Version-annotated chart resources]
Reviews (2): Last reviewed commit: "feat: annotate generated resources with ..." | Re-trigger Greptile |
Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
20cf4ac to
9a561d6
Compare
Summary
nvidia.kubernetes-launch-kit.version: <release-version>, including multi-document manifests and custom workloadsl8k versionfor the annotation valueHelm hooks and chart CRDs are excluded because Helm does not pass them through post-renderers.
Testing
go test ./... -count=1go test -race -count=1 ./pkg/networkoperatorplugin ./pkg/app ./pkg/cmd ./pkg/target/hostgolangci-lint v2.11.0 run ./...make build VERSION=v9.8.7and verifyl8k versionv9.8.7whilevalues.yamlremains unchanged