Skip to content

fix: add missing t.Helper() to renderProfile wrapper - #206

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/sriov-render-test-add-missing-t-helper-to-renderprofile
Open

fix: add missing t.Helper() to renderProfile wrapper#206
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/sriov-render-test-add-missing-t-helper-to-renderprofile

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR addresses the following issue in pkg/networkoperatorplugin/sriov_render_test.go: add missing t.Helper() to renderProfile wrapper.

Changes

  • pkg/networkoperatorplugin/sriov_render_test.go: add missing t.Helper() to renderProfile wrapper.

Details

--- a/pkg/networkoperatorplugin/sriov_render_test.go
+++ b/pkg/networkoperatorplugin/sriov_render_test.go
@@ -1,3 +1,4 @@
-func renderProfile(t *testing.T, dir, fabric, deployment string) map[string]string {
-	return renderProfileWithProfile(t, dir, &config.Profile{Fabric: fabric, Deployment: deployment, Multirail: true})
-}
+func renderProfile(t *testing.T, dir, fabric, deployment string) map[string]string {
+	t.Helper()
+	return renderProfileWithProfile(t, dir, &config.Profile{Fabric: fabric, Deployment: deployment, Multirail: true})
+}

Tests

Let me know if you want tests added for this fix or not.

Contributor guidelines

Per this repo's CONTRIBUTING.md:

  • All commits are signed off (Signed-off-by trailer, DCO).

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown

Greptile Summary

Adds t.Helper() to the renderProfile test wrapper so failures are attributed to its callers rather than the wrapper itself.

  • Improves test failure diagnostics without changing rendering behavior.

Confidence Score: 5/5

This PR appears safe to merge.

The change only improves Go test failure attribution and does not alter the helper’s inputs, rendering behavior, or returned output.

Important Files Changed

Filename Overview
pkg/networkoperatorplugin/sriov_render_test.go Correctly marks renderProfile as a test helper; no functional issues identified.

Reviews (1): Last reviewed commit: "fix: add missing t.Helper() to renderPro..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant