Skip to content

fix: RA2.2 README points to non-existent 90-pod.yaml manifest - #209

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/readme-ra2-2-readme-points-to-non-existent-90
Open

fix: RA2.2 README points to non-existent 90-pod.yaml manifest#209
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/readme-ra2-2-readme-points-to-non-existent-90

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Aug 17, 2026

Copy link
Copy Markdown

This PR corrects the documentation in profiles/spectrum-x-ra2.2/README.md: RA2.2 README points to non-existent 90-pod.yaml manifest.

Changes

  • profiles/spectrum-x-ra2.2/README.md: RA2.2 README points to non-existent 90-pod.yaml manifest.

Details

--- a/profiles/spectrum-x-ra2.2/README.md
+++ b/profiles/spectrum-x-ra2.2/README.md
@@ -1,10 +1,10 @@

 ## Testing

-Deploy the test pod to verify the configuration:
+Deploy the example DaemonSet to verify the configuration:

 ```bash
-kubectl apply -f 90-pod.yaml
+kubectl apply -f ./output/network-operator/90-example-daemonset.yaml

Check the pod has access to all rails:


## Tests

> Let me know if you want tests added for this fix or not.

## Contributor guidelines

Per this repo's [CONTRIBUTING.md](CONTRIBUTING.md):
- All commits are signed off (`Signed-off-by` trailer, DCO).

@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown

Greptile Summary

Corrects the RA2.2 testing instructions to deploy the rendered example DaemonSet from the generated Network Operator output directory.

  • Replaces the nonexistent 90-pod.yaml reference with ./output/network-operator/90-example-daemonset.yaml.
  • Updates the workload description from a test pod to an example DaemonSet.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
profiles/spectrum-x-ra2.2/README.md The revised command resolves the previously reported missing-path issue and is consistent with the documented output directory and RA2.2 template name.

Reviews (2): Last reviewed commit: "fix: RA2.2 README points to non-existent..." | Re-trigger Greptile

Comment thread profiles/spectrum-x-ra2.2/README.md Outdated
Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@andrewwhitecdw
andrewwhitecdw force-pushed the codequality/readme-ra2-2-readme-points-to-non-existent-90 branch from 4706ed0 to f3c791c Compare August 17, 2026 21:57
@andrewwhitecdw

Copy link
Copy Markdown
Author

@greptile-apps Thanks for the review. The testing command now points to the rendered DaemonSet manifest under ./output/network-operator/90-example-daemonset.yaml, matching the preceding generation instructions. I have amended the commit and pushed the update.

@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown

The README already reflects the correct path — the Testing section now reads:

kubectl apply -f ./output/network-operator/90-example-daemonset.yaml

That matches the generation step above it (kubectl apply -f ./output/network-operator/) and correctly points to the rendered output directory rather than a local file that doesn't exist. The fix looks good — thanks for the follow-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant