Skip to content

fix: RA2.2 README still references Network Operator v26.1.0 - #211

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/readme-ra2-2-readme-still-references-network
Open

fix: RA2.2 README still references Network Operator v26.1.0#211
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/readme-ra2-2-readme-still-references-network

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Aug 17, 2026

Copy link
Copy Markdown

This PR corrects the documentation in profiles/spectrum-x-ra2.2/README.md: RA2.2 README still references Network Operator v26.1.0.

Changes

  • profiles/spectrum-x-ra2.2/README.md: update the prerequisite and Helm installation example to Network Operator v26.4.0.
  • tests/test_spectrum_x_readme_versions.sh: add a regression check that fails if the README references v26.1.0 or omits v26.4.0.
  • Makefile: add a shell-tests target and include it in the ci target so the regression check runs locally.
  • .github/workflows/ci.yml: add a "Run shell regression tests" step to the test job so the check runs in CI.

Details

--- a/profiles/spectrum-x-ra2.2/README.md
+++ b/profiles/spectrum-x-ra2.2/README.md
@@ -1,3 +1,3 @@
-2. NVIDIA Network Operator v26.1.0 or later
-...
-  --version v26.1.0 \\
+2. NVIDIA Network Operator v26.4.0 or later
+...
+  --version v26.4.0 \\

Tests

make shell-tests

Result: PASS

go test ./pkg/networkoperatorplugin/... -count=1

Result: PASS

Contributor guidelines

Per this repo's CONTRIBUTING.md:

  • All commits are signed off (Signed-off-by trailer, DCO).

@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the Spectrum-X RA2.2 documentation to require Network Operator v26.4.0 and adds automated regression coverage.

  • Updates both the prerequisite and Helm installation version.
  • Adds a shell regression-test target and runs it from CI.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
profiles/spectrum-x-ra2.2/README.md Updates RA2.2 Network Operator references from v26.1.0 to v26.4.0.
tests/test_spectrum_x_readme_versions.sh Adds assertions preventing the RA2.1 version from returning and requiring the RA2.2 version.
Makefile Adds a shell-tests target and incorporates it into the aggregate CI target.
.github/workflows/ci.yml Runs the shell regression-test target in the GitHub Actions test job.

Reviews (2): Last reviewed commit: "fix: RA2.2 README still references Netwo..." | Re-trigger Greptile

#!/usr/bin/env bash
set -euo pipefail

README="profiles/spectrum-x-ra2.2/README.md"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Regression test bypasses automation

The new README assertions are not invoked by any CI workflow or Make test target, so future version regressions can pass CI unless someone runs this script manually.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

- Correct README prerequisite and Helm example to Network Operator v26.4.0.

- Add tests/test_spectrum_x_readme_versions.sh regression check.

- Wire shell regression tests into Makefile (shell-tests target) and CI workflow.

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@andrewwhitecdw
andrewwhitecdw force-pushed the bugfix/readme-ra2-2-readme-still-references-network branch from 5298a99 to 6350e41 Compare August 17, 2026 21:59
@andrewwhitecdw

Copy link
Copy Markdown
Author

@greptile-apps Thanks for the review. I wired the new shell regression test into both the Makefile (make shell-tests, now part of make ci) and the CI workflow test job, and made the script executable. make shell-tests and the Go tests both pass. Amended into the existing commit (6350e41).

@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown

Everything looks good. The Makefile shell-tests target correctly globs tests/*.sh and runs each script with bash, ci now depends on shell-tests, and the CI workflow has a dedicated step for it. The script was added with set -euo pipefail so failures will propagate correctly.

One minor nit: the shell-tests target in the Makefile invokes scripts with bash "$$script" rather than relying on the shebang, which is fine and actually more explicit — no issue there.

LGTM. This is ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant