fix: RA2.2 README still references Network Operator v26.1.0 - #211
fix: RA2.2 README still references Network Operator v26.1.0#211andrewwhitecdw wants to merge 1 commit into
Conversation
Greptile SummaryThis PR updates the Spectrum-X RA2.2 documentation to require Network Operator v26.4.0 and adds automated regression coverage.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "fix: RA2.2 README still references Netwo..." | Re-trigger Greptile |
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| README="profiles/spectrum-x-ra2.2/README.md" |
There was a problem hiding this comment.
Regression test bypasses automation
The new README assertions are not invoked by any CI workflow or Make test target, so future version regressions can pass CI unless someone runs this script manually.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
- Correct README prerequisite and Helm example to Network Operator v26.4.0. - Add tests/test_spectrum_x_readme_versions.sh regression check. - Wire shell regression tests into Makefile (shell-tests target) and CI workflow. Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
5298a99 to
6350e41
Compare
|
@greptile-apps Thanks for the review. I wired the new shell regression test into both the Makefile ( |
|
Everything looks good. The Makefile One minor nit: the LGTM. This is ready to merge. |
This PR corrects the documentation in
profiles/spectrum-x-ra2.2/README.md: RA2.2 README still references Network Operator v26.1.0.Changes
profiles/spectrum-x-ra2.2/README.md: update the prerequisite and Helm installation example to Network Operator v26.4.0.tests/test_spectrum_x_readme_versions.sh: add a regression check that fails if the README references v26.1.0 or omits v26.4.0.Makefile: add ashell-teststarget and include it in thecitarget so the regression check runs locally..github/workflows/ci.yml: add a "Run shell regression tests" step to the test job so the check runs in CI.Details
Tests
Result: PASS
Result: PASS
Contributor guidelines
Per this repo's CONTRIBUTING.md:
Signed-off-bytrailer, DCO).