fix: RA2.2 README title and versions still refer to 26.1 - #213
fix: RA2.2 README title and versions still refer to 26.1#213andrewwhitecdw wants to merge 1 commit into
Conversation
Greptile SummaryThe PR updates the RA2.2 profile documentation from Network Operator 26.1 to the 26.4 release line.
Confidence Score: 4/5The PR is not yet safe to merge because its manual installation command deploys a different chart patch than A user who installs v26.4.0 from the changed README and subsequently runs Files Needing Attention: profiles/spectrum-x-ra2.2/README.md Important Files Changed
Reviews (2): Last reviewed commit: "fix: RA2.2 README title and versions sti..." | Re-trigger Greptile |
| @@ -1,8 +1,8 @@ | |||
| # Spectrum-X Multi-Rail Profile | |||
| # Spectrum-X Multi-Rail Profile (RA2.2, Network Operator 26.4+) | |||
There was a problem hiding this comment.
Release compatibility exceeds profile bounds
When a user selects Network Operator 26.5 or later based on the new 26.4+ title or v26.4.0 or later prerequisite, the profile rejects that release because its minimum and maximum release bounds are both 26.4, preventing generation or deployment.
Knowledge Base Used:
Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
7b019d5 to
49eaf7c
Compare
|
@greptile-apps Thanks for the review. I have corrected the compatibility wording to match the profile release bounds: the title now reads |
|
All three locations are correctly updated — the title, the prerequisite line, and the Helm install command all now consistently read |
| --namespace nvidia-network-operator \ | ||
| --create-namespace \ | ||
| --version v26.1.0 \ | ||
| --version v26.4.0 \ |
There was a problem hiding this comment.
Documented chart conflicts with catalog
When a user installs Network Operator v26.4.0 with this command and later runs l8k deploy for release 26.4, the embedded catalog resolves the expected chart to v26.4.1, causing deployment to abort with a chart-version conflict and exit code 4.
Knowledge Base Used: Spectrum-X addressing and topology
This PR corrects the documentation in
profiles/spectrum-x-ra2.2/README.md: RA2.2 README title and versions still refer to 26.1.Changes
profiles/spectrum-x-ra2.2/README.md: RA2.2 README title and versions still refer to 26.1.Details
Tests
profiles/spectrum-x-ra2.2/README.mdContributor guidelines
Per this repo's CONTRIBUTING.md:
Signed-off-bytrailer, DCO).