Skip to content

fix: RA2.3 README points to non-existent 90-pod.yaml manifest - #216

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/readme-ra2-3-readme-points-to-non-existent-90
Open

fix: RA2.3 README points to non-existent 90-pod.yaml manifest#216
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/readme-ra2-3-readme-points-to-non-existent-90

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR corrects the documentation in profiles/spectrum-x/README.md: RA2.3 README points to non-existent 90-pod.yaml manifest.

Changes

  • profiles/spectrum-x/README.md: RA2.3 README points to non-existent 90-pod.yaml manifest.

Details

--- a/profiles/spectrum-x/README.md
+++ b/profiles/spectrum-x/README.md
@@ -1,1 +1,1 @@
-kubectl apply -f 90-pod.yaml
+kubectl apply -f 90-example-daemonset.yaml

Tests

  • profiles/spectrum-x/test_readme.py
--- /dev/null
+++ b/profiles/spectrum-x/test_readme.py
@@ -0,0 +1,11 @@
+import re
+from pathlib import Path
+
+
+def test_readme_apply_targets_exist_in_generated_list():
+    readme = Path(__file__).with_name('README.md')
+    content = readme.read_text()
+    generated = set(re.findall(r'`(\d{2}-[\w-]+\.yaml)`', content))
+    apply_targets = re.findall(r'kubectl apply -f\s+(\S+\.yaml)', content)
+    missing = [t for t in apply_targets if Path(t).name not in generated]
+    assert not missing, f'ReADME kubectl apply targets not listed as generated: {missing}'

Contributor guidelines

Per this repo's CONTRIBUTING.md:

  • All commits are signed off (Signed-off-by trailer, DCO).

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown

Greptile Summary

Corrects the RA2.3 Spectrum-X testing command to reference the existing example DaemonSet manifest instead of the nonexistent pod manifest.

  • Updates profiles/spectrum-x/README.md from 90-pod.yaml to 90-example-daemonset.yaml.

Confidence Score: 5/5

The documentation-only correction appears safe to merge.

The replacement target exists in the RA2.3 profile and is the intended example workload for the following Spectrum-X rail validation steps.

Important Files Changed

Filename Overview
profiles/spectrum-x/README.md The updated command now names the example workload included by the RA2.3 profile; no actionable regression was established.

Reviews (1): Last reviewed commit: "fix: RA2.3 README points to non-existent..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant