Skip to content

fix: quote numeric deviceID example to match declared string type - #218

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/config-schema-quote-numeric-deviceid-example-to
Open

fix: quote numeric deviceID example to match declared string type#218
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/config-schema-quote-numeric-deviceid-example-to

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR addresses the following issue in skills/k8s-network-engineer/references/config-schema.md: quote numeric deviceID example to match declared string type.

Changes

  • skills/k8s-network-engineer/references/config-schema.md: quote numeric deviceID example to match declared string type.

Details

--- a/skills/k8s-network-engineer/references/config-schema.md
+++ b/skills/k8s-network-engineer/references/config-schema.md
@@ -1,17 +1,17 @@
-      - deviceID: 1023
-        pciAddress: "0000:05:00.0"
-        rdmaDevice: ""
-        networkInterface: ""
-        traffic: east-west
-        rail: 0
-      - deviceID: 1023
-        pciAddress: "0000:75:00.0"
-        rdmaDevice: ""
-        networkInterface: ""
-        traffic: east-west
-        rail: 1
-      - deviceID: 1023
-        pciAddress: "0000:6a:00.0"
-        rdmaDevice: ""
-        networkInterface: ""
-        traffic: north-south
+      - deviceID: "1023"
+        pciAddress: "0000:05:00.0"
+        rdmaDevice: ""
+        networkInterface: ""
+        traffic: east-west
+        rail: 0
+      - deviceID: "1023"
+        pciAddress: "0000:75:00.0"
+        rdmaDevice: ""
+        networkInterface: ""
+        traffic: east-west
+        rail: 1
+      - deviceID: "1023"
+        pciAddress: "0000:6a:00.0"
+        rdmaDevice: ""
+        networkInterface: ""
+        traffic: north-south

Tests

Let me know if you want tests added for this fix or not.

Contributor guidelines

Per this repo's CONTRIBUTING.md:

  • All commits are signed off (Signed-off-by trailer, DCO).

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown

Greptile Summary

Corrects the agent-facing configuration example so numeric-looking deviceID values are represented as strings, matching the declared schema.

  • Quotes all three deviceID: 1023 values in the physical-function example.
  • Leaves the example’s values and surrounding configuration unchanged.

Confidence Score: 5/5

The PR appears safe to merge because it only corrects YAML scalar typing in an agent-facing example.

The three edited values now deserialize as strings while preserving their intended device identifiers and the rest of the example.

Important Files Changed

Filename Overview
skills/k8s-network-engineer/references/config-schema.md Quotes three numeric-looking device IDs to align the YAML example with the field’s string type; no issues identified.

Reviews (1): Last reviewed commit: "fix: quote numeric deviceID example to m..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant