fix: keep host-device components in NicClusterPolicy

[almaslennikov]

Summary

• delete profiles/host-device-rdma/11-nicnodepolicy.yaml and remove it from the host-device profile
• always render the host-device OFED driver and SR-IOV device plugin through the singleton NicClusterPolicy
• update the existing maintenance rendering expectation for the permanent policy placement

This avoids Network Operator deriving an overlong SR-IOV device-plugin DaemonSet name from a host-device NicNodePolicy. Support can be enabled again with Network Operator 26.10.

Testing

• CGO_ENABLED=0 go test ./... -count=1
• CGO_ENABLED=0 go build ./...
• CGO_ENABLED=0 go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.11.0 run ./...
• git diff --check

[greptile-apps]

Greptile Summary

The PR permanently moves host-device OFED and SR-IOV device-plugin configuration into the singleton NicClusterPolicy to avoid overlong DaemonSet names.

• Removes the release-dependent NicNodePolicy template from the host-device profile.
• Makes the NicClusterPolicy component configuration apply to every supported release.
• Updates maintenance-rendering expectations for the new manifest placement.

Confidence Score: 4/5

The PR does not appear safe to merge because merged multirail deployments can still omit valid PCI addresses from SR-IOV resource selectors.

The singleton NicClusterPolicy calls legacySriovDevicePluginConfigList, which reads representative PF addresses while merged configurations place the complete address set in RailPciAddresses; nodes using non-representative addresses therefore remain excluded from the expected rail resource.

Files Needing Attention: profiles/host-device-rdma/10-nicclusterpolicy.yaml and pkg/networkoperatorplugin/templates.go

Important Files Changed

Filename	Overview
profiles/host-device-rdma/10-nicclusterpolicy.yaml	Makes host-device OFED and SR-IOV plugin configuration permanent in the singleton NicClusterPolicy.
profiles/host-device-rdma/11-nicnodepolicy.yaml	Removes the release-gated NicNodePolicy previously used for host-device components.
profiles/host-device-rdma/profile.yaml	Removes the deleted NicNodePolicy template from the ordered profile manifest list.
pkg/networkoperatorplugin/maintenance_render_test.go	Updates maintenance rendering expectations to locate host-device upgrade policy configuration in NicClusterPolicy.

_{Reviews (3): Last reviewed commit: "fix: keep host-device components in NicC..." | Re-trigger Greptile}

[almaslennikov]

Updated the PR scope and force-pushed d521ed3:

1. Release-specific gating and tests removed. The host-device profile now omits 11-nicnodepolicy.yaml entirely and renders its OFED driver and SR-IOV device plugin unconditionally in NicClusterPolicy.
2. Rail aggregation helper unchanged. The suggested helper expansion is outside this profile-only change; the PR retains the existing cluster-wide configuration behavior.

Validation is clean: CGO_ENABLED=0 go test ./... -count=1, CGO_ENABLED=0 go build ./..., golangci-lint v2.11, and git diff --check.

[almaslennikov]

Corrected the remaining scope gap and force-pushed 21c9b4b:

1. Deleted profiles/host-device-rdma/11-nicnodepolicy.yaml, rather than only removing its profile-list entry.
2. The host-device profile now renders the OFED driver and SR-IOV device plugin only through its singleton NicClusterPolicy.

Validation is green locally: full tests, build, golangci-lint, and git diff --check.