Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NeMo Customizer #305

Merged
merged 8 commits into from
Feb 4, 2025
Merged

Add support for NeMo Customizer #305

merged 8 commits into from
Feb 4, 2025

Conversation

shivamerla
Copy link
Collaborator

No description provided.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 30, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shivamerla shivamerla requested a review from shengnuo January 31, 2025 14:06
@shivamerla shivamerla force-pushed the add_nemo_customizer_support branch from b3f6c00 to ad941a9 Compare January 31, 2025 14:10
@shivamerla shivamerla requested review from varunrsekar and removed request for ArangoGutierrez January 31, 2025 14:45
varunrsekar
varunrsekar reviewed Jan 31, 2025
View reviewed changes
@shivamerla
Add support for NeMo Customizer
78c3cb6 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
@shivamerla
Generate client-set and typo fixes
90a61b6 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
@shivamerla
Update spec and remove redundant validation markers
4e77f74 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
@shivamerla
Fix service type param setting
977e421 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
@shivamerla shivamerla force-pushed the add_nemo_customizer_support branch from 8af2740 to 977e421 Compare February 1, 2025 05:05
visheshtanksale
visheshtanksale previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@visheshtanksale visheshtanksale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

varunrsekar
varunrsekar reviewed Feb 3, 2025
View reviewed changes
@shivamerla
Add startup probe
0270e67 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
slu2011
slu2011 reviewed Feb 3, 2025
View reviewed changes
@shivamerla
Rename hashing function
ad389fa 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
@shivamerla
Fix lint
1bcb37d 
Signed-off-by: Shiva Krishna, Merla <[email protected]>
visheshtanksale
visheshtanksale approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@visheshtanksale visheshtanksale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@shivamerla shivamerla merged commit c67e045 into NVIDIA:main Feb 4, 2025
9 checks passed
@shivamerla shivamerla self-assigned this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shengnuo shengnuo shengnuo left review comments

@varunrsekar varunrsekar varunrsekar left review comments

@slu2011 slu2011 slu2011 approved these changes

@visheshtanksale visheshtanksale visheshtanksale approved these changes

Assignees

@shivamerla shivamerla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shivamerla @slu2011 @shengnuo @varunrsekar @visheshtanksale