Updating multi LLM samples without precaching #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visheshtanksale
requested review from
ArangoGutierrez,
shengnuo,
shivamerla,
slu2011 and
varunrsekar
as code owners
mkhaas
reviewed
Sep 4, 2025
| env: | ||
| - name: NIM_MODEL_NAME | ||
| value: nvidia/nemo/llama-3_2-1b-instruct | ||
| value: 'ngc://nvidian/nim-llm-dev/meta-llama3-8b-instruct:hf' |
There was a problem hiding this comment.
this is internal NGC repository. Let's remove it for now? thanks
Signed-off-by: Vishesh Tanksale <[email protected]>
visheshtanksale
force-pushed
the
multi-llm-samples
branch
from
08c3e04 to
0005c90
Compare
shivamerla
reviewed
Sep 16, 2025
| env: | ||
| - name: NIM_MODEL_NAME | ||
| value: hf://meta-llama/Llama-3.2-1B-Instruct | ||
| - name: HF_TOKEN |
There was a problem hiding this comment.
This will need to be part of secret as well, in this case we should not make NGC_API_KEY checks in the code mandatory and export all env from the secret instead.
There was a problem hiding this comment.
Yes thats the fix. But this PR is just to fix the sample for v3.0.0 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.