Add vulkan sample image #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
add-vulkan-sample
branch
from
d95c34f to
2d80bea
Compare
ArangoGutierrez
approved these changes
Mar 18, 2025
guptaNswati
reviewed
Mar 18, 2025
| @@ -0,0 +1,65 @@ | |||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
There was a problem hiding this comment.
It's a tag to improve machine-readability of the license headers.
guptaNswati
reviewed
Mar 18, 2025
| libglm-dev \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # TODO: We should update to the official samples |
There was a problem hiding this comment.
Curious, why are we not using the official ones in this build?
There was a problem hiding this comment.
I did not want to change how the samples are being built when compared to https://gitlab.com/nvidia/container-images/vulkan/-/blame/master/samples/Dockerfile.ubuntu?ref_type=heads#L35 in this commit.
Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
add-vulkan-sample
branch
from
2d80bea to
3df6fd5
Compare
|
cc @dualvtable |
This change adds a sample image that can be used to demonstrate vulkan functionality. Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
add-vulkan-sample
branch
from
38c01b5 to
72a3b6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a vulkan sample image to replace the image(s) defined at https://gitlab.com/nvidia/container-images/vulkan