Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add benchmark for network topology with requiredDuringSchedulingIgnoredDuringExecution #112

Merged
merged 1 commit into from
Dec 11, 2024
Merged

add benchmark for network topology with requiredDuringSchedulingIgnoredDuringExecution #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions resources/benchmarks/nwtopo/templates/jobset/jobset-acc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
# Copyright (c) 2024, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

apiVersion: jobset.x-k8s.io/v1alpha2
kind: JobSet
metadata:
name: "{{._NAME_}}"
namespace: default
spec:
# We want to declare our JobSet successful if workers finish.
# If workers finish we should clean up the remaining replicatedJobs.
successPolicy:
operator: All
targetReplicatedJobs:
- workers
replicatedJobs:
- name: workers
replicas: 1
template:
spec:
backoffLimit: 0
completions: {{.replicas}}
parallelism: {{.replicas}}
completionMode: NonIndexed
template:
metadata:
labels:
app: {{._NAME_}}
annotations:
pod-complete.stage.kwok.x-k8s.io/delay: "{{.ttl}}"
pod-complete.stage.kwok.x-k8s.io/jitter-delay: "{{.ttl}}"
spec:
schedulerName: default-scheduler
affinity:
podAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
- labelSelector:
matchExpressions:
- key: app
operator: In
values:
- {{._NAME_}}
topologyKey: network.topology.kubernetes.io/accelerator
containers:
- name: test
image: ubuntu
imagePullPolicy: IfNotPresent
resources:
limits:
cpu: 100m
memory: 250M
nvidia.com/gpu: "8"
requests:
cpu: 100m
memory: 250M
nvidia.com/gpu: "8"
4 changes: 2 additions & 2 deletions resources/benchmarks/nwtopo/templates/jobset/jobset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ spec:
operator: In
values:
- {{._NAME_}}
topologyKey: net-layer-2
topologyKey: network.topology.kubernetes.io/spine
- weight: 90
podAffinityTerm:
labelSelector:
Expand All @@ -62,7 +62,7 @@ spec:
operator: In
values:
- {{._NAME_}}
topologyKey: net-layer-1
topologyKey: network.topology.kubernetes.io/block
containers:
- name: test
image: ubuntu
Expand Down
4 changes: 2 additions & 2 deletions resources/benchmarks/nwtopo/templates/runai/mpijob.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
operator: In
values:
- {{._NAME_}}
topologyKey: net-layer-2
topologyKey: network.topology.kubernetes.io/spine
- weight: 90
podAffinityTerm:
labelSelector:
Expand All @@ -60,7 +60,7 @@ spec:
operator: In
values:
- {{._NAME_}}
topologyKey: net-layer-1
topologyKey: network.topology.kubernetes.io/block
schedulerName: runai-scheduler
containers:
- image: runai/mpi-worker:latest
Expand Down
23 changes: 23 additions & 0 deletions resources/benchmarks/nwtopo/workflows/config-jobset-acc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Copyright (c) 2024, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

name: config-jobset
tasks:
- id: register
type: RegisterObj
params:
template: "resources/benchmarks/nwtopo/templates/jobset/jobset-acc.yaml"
nameFormat: "jobset{{._ENUM_}}"
podNameFormat: "{{._NAME_}}-workers-[0-9]+-.+"
podCount: "{{.replicas}}"
145 changes: 145 additions & 0 deletions resources/benchmarks/nwtopo/workflows/config-nodes-acc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,145 @@
# Copyright (c) 2024, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

name: config-nw-topo-nodes
description: |
Create a 12-nodes cluster with a tree-like network topology
and mark 5 nodes as busy:
__________ sw31 __________
/ | \
sw21 sw22 sw23
/ \ / \ / \
sw11 sw12 sw13 sw14 sw15 sw16
/\ /\ /\ /\ /\ /\
n1 n2 n3 n4 n5 n6 n7 n8 n9 n10 n11 n12
|___|___|___|___|___| |___|___|___|___|___|
| |
nvl1 nvl2

Then deploy a 3-replicas job. The optimal nodes from the
network topology perspective for this job are nodes n5, n7, n8.
tasks:
- id: configure
type: Configure
params:
nodes:
- type: dgxa100.80g
count: 1
labels:
node-id: n1
network.topology.kubernetes.io/accelerator: nvl1
network.topology.kubernetes.io/block: sw11
network.topology.kubernetes.io/spine: sw21
network.topology.kubernetes.io/datacenter: sw31
nvidia.com/gpu.count: "8"
- type: dgxa100.80g
count: 1
labels:
node-id: n2
network.topology.kubernetes.io/accelerator: nvl1
network.topology.kubernetes.io/block: sw11
network.topology.kubernetes.io/spine: sw21
network.topology.kubernetes.io/datacenter: sw31
nvidia.com/gpu.count: "8"
- type: dgxa100.80g
count: 1
labels:
node-id: n3
network.topology.kubernetes.io/accelerator: nvl1
network.topology.kubernetes.io/block: sw12
network.topology.kubernetes.io/spine: sw21
network.topology.kubernetes.io/datacenter: sw31
nvidia.com/gpu.count: "8"
- type: dgxa100.80g
count: 1
labels:
node-id: n4
network.topology.kubernetes.io/accelerator: nvl1
network.topology.kubernetes.io/block: sw12
network.topology.kubernetes.io/spine: sw21
network.topology.kubernetes.io/datacenter: sw31
nvidia.com/gpu.count: "8"
- type: dgxa100.80g
count: 1
labels:
node-id: n5
network.topology.kubernetes.io/accelerator: nvl1
network.topology.kubernetes.io/block: sw13
network.topology.kubernetes.io/spine: sw22
network.topology.kubernetes.io/datacenter: sw31
nvidia.com/gpu.count: "8"
- type: dgxa100.80g
count: 1
labels:
node-id: n6
network.topology.kubernetes.io/accelerator: nvl1
network.topology.kubernetes.io/block: sw13
network.topology.kubernetes.io/spine: sw22
network.topology.kubernetes.io/datacenter: sw31
nvidia.com/gpu.count: "8"
- type: dgxa100.80g
count: 1
labels:
node-id: n7
network.topology.kubernetes.io/accelerator: nvl2
network.topology.kubernetes.io/block: sw14
network.topology.kubernetes.io/spine: sw22
network.topology.kubernetes.io/datacenter: sw31
nvidia.com/gpu.count: "8"
- type: dgxa100.80g
count: 1
labels:
node-id: n8
network.topology.kubernetes.io/accelerator: nvl2
network.topology.kubernetes.io/block: sw14
network.topology.kubernetes.io/spine: sw22
network.topology.kubernetes.io/datacenter: sw31
nvidia.com/gpu.count: "8"
- type: dgxa100.80g
count: 1
labels:
node-id: n9
network.topology.kubernetes.io/accelerator: nvl2
network.topology.kubernetes.io/block: sw15
network.topology.kubernetes.io/spine: sw23
network.topology.kubernetes.io/datacenter: sw31
nvidia.com/gpu.count: "8"
- type: dgxa100.80g
count: 1
labels:
node-id: n10
network.topology.kubernetes.io/accelerator: nvl2
network.topology.kubernetes.io/block: sw15
network.topology.kubernetes.io/spine: sw23
network.topology.kubernetes.io/datacenter: sw31
nvidia.com/gpu.count: "8"
- type: dgxa100.80g
count: 1
labels:
node-id: n11
network.topology.kubernetes.io/accelerator: nvl2
network.topology.kubernetes.io/block: sw16
network.topology.kubernetes.io/spine: sw23
network.topology.kubernetes.io/datacenter: sw31
nvidia.com/gpu.count: "8"
- type: dgxa100.80g
count: 1
labels:
node-id: n12
network.topology.kubernetes.io/accelerator: nvl2
network.topology.kubernetes.io/block: sw16
network.topology.kubernetes.io/spine: sw23
network.topology.kubernetes.io/datacenter: sw31
nvidia.com/gpu.count: "8"
timeout: 5m
Loading
Loading