Add the cleanup support #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanchen8911
force-pushed
the
cleanup
branch
2 times, most recently
from
8a4440a to
8f421ef
Compare
yuanchen8911
removed
help wanted
dmitsh
reviewed
May 16, 2024
| for _, name := range objInfo.Names { | ||
| err := eng.dynamicClient.Resource(objInfo.GVR).Namespace(ns).Delete(ctx, name, deletions) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Would it return an error if the object has been already deleted by the test or expired naturally?
There was a problem hiding this comment.
Is the following the correct way to add a DeleteObj task? The SubmitObj task's id is job.
- id: delete
type: DeleteObj
params:
refTaskId: job
refTaskId: job
After adding the above task to k8s/test-job.yaml, i ran the test (without --cleanup) and got the following error.
E0516 09:56:44.038701 53311 engine.go:200] "Task failed" err="the server could not find the requested resource" id="DeleteObj/delete"
I0516 09:56:44.038712 53311 engine.go:209] "Reset Engine"
E0516 09:56:44.038718 53311 main.go:96] the server could not find the requested resource
There was a problem hiding this comment.
Also, I was wondering why we need to define refTaskId twice in DeleteObj.
There was a problem hiding this comment.
No, we don't need refTaskId twice.
There was a problem hiding this comment.
I removed the second refTaskId and still got the same error. Do we have a test with a DeleteObj task other than the unit test? Can you test the DeleteObj task by yourself?
./bin/knavigator --tasks resources/tests/k8s/test-job.yml
I0516 10:15:41.155408 53935 k8s_config.go:42] "Using external kubeconfig"
I0516 10:15:41.158578 53935 main.go:84] "Starting test" name="test-k8s-job"
I0516 10:15:41.158590 53935 engine.go:103] "Creating task" name="SubmitObj" id="job"
I0516 10:15:41.160156 53935 engine.go:197] "Starting task" id="SubmitObj/job"
I0516 10:15:41.182176 53935 engine.go:203] "Task completed" id="SubmitObj/job" duration="22.011666ms"
I0516 10:15:41.182188 53935 engine.go:103] "Creating task" name="DeleteObj" id="delete"
I0516 10:15:41.182224 53935 engine.go:197] "Starting task" id="DeleteObj/delete"
E0516 10:15:41.184724 53935 engine.go:200] "Task failed" err="the server could not find the requested resource" id="DeleteObj/delete"
I0516 10:15:41.184735 53935 engine.go:209] "Reset Engine"
E0516 10:15:41.184741 53935 main.go:96] the server could not find the requested resource
There was a problem hiding this comment.
indeed, we never tested it. Let me check
There was a problem hiding this comment.
A bug indeed. Fixed in #41
There was a problem hiding this comment.
I tested --cleanup with and without the DeleteObj task. It workded well. For the case with DeleteObj, there's no error. The deleted object should have been removed from eng.objInfoMap?
./bin/knavigator --tasks resources/tests/k8s/test-job.yml --cleanup
I0517 10:24:41.489049 93711 k8s_config.go:42] "Using external kubeconfig"
I0517 10:24:41.494671 93711 main.go:84] "Starting test" name="test-k8s-job"
I0517 10:24:41.494690 93711 engine.go:111] "Creating task" name="RegisterObj" id="register"
I0517 10:24:41.495255 93711 engine.go:244] "Starting task" id="RegisterObj/register"
I0517 10:24:41.495266 93711 engine.go:250] "Task completed" id="RegisterObj/register" duration="1.708µs"
I0517 10:24:41.495271 93711 engine.go:111] "Creating task" name="SubmitObj" id="job"
I0517 10:24:41.495349 93711 engine.go:244] "Starting task" id="SubmitObj/job"
I0517 10:24:41.512305 93711 engine.go:250] "Task completed" id="SubmitObj/job" duration="16.949084ms"
I0517 10:24:41.512316 93711 engine.go:111] "Creating task" name="CheckPod" id="status"
I0517 10:24:41.512363 93711 engine.go:244] "Starting task" id="CheckPod/status"
I0517 10:24:41.512369 93711 check_pod_task.go:158] "Create pod informer" #pod=2 timeout="5s"
I0517 10:24:41.517275 93711 check_pod_task.go:256] "Accounted for all pods"
I0517 10:24:41.517300 93711 engine.go:250] "Task completed" id="CheckPod/status" duration="4.932042ms"
I0517 10:24:41.517317 93711 engine.go:111] "Creating task" name="DeleteObj" id="delete"
I0517 10:24:41.517385 93711 engine.go:244] "Starting task" id="DeleteObj/delete"
W0517 10:24:41.529210 93711 warnings.go:70] child pods are preserved by default when jobs are deleted; set propagationPolicy=Background to remove them or set propagationPolicy=Orphan to suppress this warning
I0517 10:24:41.529230 93711 engine.go:250] "Task completed" id="DeleteObj/delete" duration="11.837917ms"
I0517 10:24:41.529235 93711 engine.go:256] "Reset Engine"
I0517 10:24:41.529237 93711 engine.go:262] "Cleaning up objects"
I0517 10:24:41.533397 93711 engine.go:286] "Deleted all objects"
Signed-off-by: Yuan Chen <[email protected]> Update engine Signed-off-by: Yuan Chen <[email protected]> Resolve conflicts Signed-off-by: Yuan Chen <[email protected]> Update main.go Implement DeleteAllObjects Signed-off-by: Yuan Chen <[email protected]> Fix a golint error Signed-off-by: Yuan Chen <[email protected]> Remove a comment Signed-off-by: Yuan Chen <[email protected]>
dmitsh
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
cleanupoption to delete all jobs and pods in a test.--cleanup-- cleanup.timeoutThe initial verification shows it works.
--cleanup, the job remained.--cleanup, the job was delete.Verified it works for volcano jobs too.