socket: handle short read of the magic #1613
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kiskra-nvidia Can you help have a look at this issue? We hit it recently. It seems that previous fix missed something. |
nmap will reset the TCP connection without sending any data during port scanning. As a result, the bootstrap will fail. This patch fixes the issue by ignore connections that have not send the whole magic before closing. Closes NVIDIA#1612
|
@gangxie112 Are you saying that this PR doesn't fully solve the issue for you? Do you have specific instructions on how to reproduce? I'm a bit surprised that this triggers during the bootstrap for you, given that that stage should take just a few seconds. Are you running nmap in a loop or something? |
|
@kiskra-nvidia we have verified that the PR does fix the issue. We reproduced the issue by IP=10.0.0.7
nmap -sT $IP -p 40000-60000Since the bootstrap takes only a few seconds, we don't hit the issue often. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nmap will reset the TCP connection without sending any data during port scanning. As a result, the bootstrap will fail.
This patch fixes the issue by ignore connections that have not send the whole magic before closing.
Closes #1612