Fix for various issues in the graph module #1635
Open
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -328,8 +328,7 @@ ncclResult_t ncclTopoReplayGetGpu(struct ncclTopoSystem* system, struct ncclTopo | |||
| *g = i; | |||
| return ncclSuccess; | |||
| } | |||
| if (*g == -1) return ncclInternalError; | |||
| return ncclSuccess; | |||
| return ncclInternalError; | |||
There was a problem hiding this comment.
In the for-loop above, if a GPU with the specified rank is found, the function sets *g to the index of the GPU and return ncclSuccess. If the for-loop completes without returning, *g would remain as the initial value of -1, therefore the if-statement for checking *g value is redundant. It also means the final return statement will be unreachable.
The fix removes the redundant if-statement and return ncclInternalError directly.
| do { | ||
| NCCLCHECK(xmlGetChar(file, &c)); | ||
| value[o++] = c; | ||
| } while (c != '"'); | ||
| } while (c != quote); |
There was a problem hiding this comment.
The fix allows the quote to be either " or ', and correctly matches the ending quote.
eleanorTurintech
changed the title
|
Thanks, @eleanorTurintech ! I've upstreamed your change into what should be our next new release, v2.27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pr aims to fix some issues in the graph/ module. The details are as follows: