[no-relnote] cleanup /etc/cdi/nvidia.yaml on uninstall #1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jcpunk
force-pushed
the
ghost-file-config
branch
2 times, most recently
from
b915e99 to
4f566c7
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds cleanup of the generated /etc/cdi/nvidia.yaml file when uninstalling the NVIDIA container toolkit packages.
- Marks
/etc/cdi/nvidia.yamlas a ghost config in the RPM spec - Adjusts Debian postrm hooks to remove the toolkit symlink on
removeand clean upnvidia.yamlin the base package - Introduces a new Debian postrm script for the base package to delete the stale
nvidia.yamlon purge/remove
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packaging/rpm/SPECS/nvidia-container-toolkit.spec | Declares /etc/cdi/nvidia.yaml as a %config(noreplace) %ghost |
| packaging/debian/nvidia-container-toolkit.postrm | Expands purge to `purge |
| packaging/debian/nvidia-container-toolkit-base.postrm | New script to delete /etc/cdi/nvidia.yaml on purge/remove |
Comments suppressed due to low confidence (1)
packaging/debian/nvidia-container-toolkit-base.postrm:7
- [nitpick] There’s no automated test verifying that
/etc/cdi/nvidia.yamlis removed on purge/remove. Adding a simple integration test for the postrm behavior would help catch regressions.
/bin/rm -f /etc/cdi/nvidia.yaml
Pull Request Test Coverage Report for Build 16174536002Details
💛 - Coveralls |
elezar
reviewed
Jul 10, 2025
|
I'm not sure |
Signed-off-by: Pat Riehecky <[email protected]>
jcpunk
force-pushed
the
ghost-file-config
branch
from
a1acd4e to
5596450
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cleanup of
/etc/cdi/nvidia.yamlupon uninstallation (not upgrade) of thenvidia-container-toolkit-basepackage.When things are truly screwed up on my system, uninstall and reinstall of the nvidia components is a quick way to get back to a known state. However, since the current packages don't track the CDI config, a broken nvidia.yaml can persist on the system. If I don't remember I generated this file, I wont remember to remake it. My existing config management notices when the file is missing and builds it automatically.