[no-relnote] implement defaultRuntimesGetter interface #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new defaultRuntimesGetter interface to replace the broader Interface type in two functions, reducing interface coupling and preparing for future changes.
- Introduces
defaultRuntimesGetterinterface with two methods:DefaultRuntime()andGetRuntimeConfig() - Updates
GetBinaryPathsForRuntimes()andGetLowLevelRuntimes()to use the narrower interface
|
Since #1280 has already been merged, I don't think this is required anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to further reduce the diff in #1280