Add rockylinux 8 as an RPM builder #1364
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… features newer releases require Signed-off-by: Ehren Bendler <[email protected]>
ArangoGutierrez
requested changes
Nov 4, 2025
| *) echo "unsupported architecture" ; exit 1 ;; \ | ||
| esac; \ | ||
| wget -nv -O - https://storage.googleapis.com/golang/go${GOLANG_VERSION}.linux-${ARCH}.tar.gz \ | ||
| wget -nv -O - https://dl.google.com/go/go${GOLANG_VERSION}.linux-${ARCH}.tar.gz \ |
There was a problem hiding this comment.
This change looks out of scope for the commit. (PR description does mention it.
I would prefer to have the 4 items listed on the PR description as standalone commits:
- scrub centos from the release process, its dead
- update golang URLs to newer google endpoints
- replace all centos-stream:8 usage with rockylinux:8
- add "dist" tag to RPMs to distinguish el7 and el8 builds
There was a problem hiding this comment.
My understanding is that you're moving to kitmaker in the near-ish future, so this PR is largely pointless. I thought @elezar was going to close it, but don't spend any energy on it.
| amazonlinux*) pkg_type=rpm | ||
| ;; | ||
| centos* | rpm) pkg_type=rpm | ||
| centos* | rhel* | rpm) pkg_type=rpm |
There was a problem hiding this comment.
If we are getting rid of CentOS, does it make sense to continue to list it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that RPMs have the fields that newer releases require.
Also:
This will fail CI until this libnvidia-container PR is merged. Come back and update this PR with new third_party pointer when that happens. NVIDIA/libnvidia-container#329