Fix ldcache update on non debian systems #1444
Open
+48
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/cherry-pick release-1.18 |
This was referenced Nov 11, 2025
elezar
force-pushed
the
fix-ldcache-update-on-non-debian
branch
2 times, most recently
from
9a32323 to
fb95f58
Compare
elezar
force-pushed
the
fix-ldcache-update-on-non-debian
branch
3 times, most recently
from
aa0c6fa to
a854d3d
Compare
cdesiniotis
approved these changes
Nov 14, 2025
Contributor
cdesiniotis
left a comment
cdesiniotis
left a comment
There was a problem hiding this comment.
I left a couple of comments / questions, but no blockers.
internal/ldconfig/ldconfig.go
Outdated
| if len(args) < 1 { | ||
| return nil, fmt.Errorf("incorrect arguments: %v", args) | ||
| } | ||
| fs := flag.NewFlagSet(args[1], flag.ExitOnError) |
Contributor
There was a problem hiding this comment.
Question -- is args[1] the right name to give to this flag set? What about something along the lines of ldconfig-options?
Member
Author
There was a problem hiding this comment.
You're right. This was definitely a copy-paste error on my part.
elezar
force-pushed
the
fix-ldcache-update-on-non-debian
branch
from
a854d3d to
2794eaa
Compare
This change ensures that the ldcache in a non-debian container includes libraries at /lib64 and /usr/lib64 when running on debian host. This is required because the system search paths do not include these folders by default resulting in a non-debian container missing system libraries from the ldcache. Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
fix-ldcache-update-on-non-debian
branch
from
2794eaa to
0b28791
Compare
jfroy
reviewed
Nov 14, 2025
| func (l *Ldconfig) getSystemSerachPaths() []string { | ||
| func (l *Ldconfig) getSystemSearchPaths() []string { | ||
| if l.isDebianLikeContainer { | ||
| debianSystemSearchPaths() |
There was a problem hiding this comment.
I've been debugging issues on my homelab cluster with the latest CTK release, and I just spotted this code here. I think it's missing a return. I can send a PR for the existing code, or we can roll that fix into this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the update of the ldcache when running a non-debian (including ubuntu) container on a debian-like system. Here the ldcache in the container does not initially include system libraries from
/lib64or/usr/lib64since thisldconfigfrom the host that is executed in the container's namespace does not process those paths by default.This is related to #1403 and will need to be updated once that is merged since we would also need to NOT include
lib64and/usr/lib64in the list of folders if it's already present in the config folders for some reason.Testing
The expected behaviour when using
runcdirectly:The current behaviour:
(note that
libc.so.6is not present in the ldcache since/lib64(linked to/usr/lib64) is not processed).The updated behaviour: