Skip to content

Fix multicast TTL when updating SDP destinations - #109

Merged
garethsb merged 1 commit into
NVIDIA:mainfrom
garethsb:bugfix/multicast-sdp-ttl
Aug 18, 2026
Merged

Fix multicast TTL when updating SDP destinations#109
garethsb merged 1 commit into
NVIDIA:mainfrom
garethsb:bugfix/multicast-sdp-ttl

Conversation

@garethsb

Copy link
Copy Markdown
Collaborator

Summary

  • preserve an explicit multicast TTL when gst-nmos-rs overrides an SDP destination
  • apply the gst-nmos-rs multicast default when an override changes a no-TTL destination to multicast, and clear TTL state for unicast
  • default a zero configuring-SDP TTL before nvnmos regenerates a sender transport file after IS-05 activation

This fixes the zero-TTL behavior reported by @souravpaul98 when a caps-only nmossink starts with the unspecified 0.0.0.0 destination and IS-05 later assigns a multicast address.

Test plan

  • cargo fmt -p gst-nmos-rs -- --check
  • cargo test -p gst-nmos-rs --lib
  • cargo test -p gst-nmos-rs --lib -- --test-threads=1
  • build libnvnmos against the current nmos-cpp main revision
  • end-to-end nvnmosd test: activate a sender from c=IN IP4 0.0.0.0 to multicast and verify /transportfile contains /32

Preserve explicit multicast TTLs, supply defaults when destinations change to multicast, and align gst-nmos-rs synthesis with the nmos-cpp and nvnmos default of 32.

Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
@garethsb
garethsb force-pushed the bugfix/multicast-sdp-ttl branch from f405a7f to cbb8667 Compare August 18, 2026 11:04
@garethsb
garethsb merged commit e632884 into NVIDIA:main Aug 18, 2026
8 checks passed
@garethsb
garethsb deleted the bugfix/multicast-sdp-ttl branch August 18, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant