Fix multicast TTL when updating SDP destinations - #109
Merged
Conversation
Preserve explicit multicast TTLs, supply defaults when destinations change to multicast, and align gst-nmos-rs synthesis with the nmos-cpp and nvnmos default of 32. Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
garethsb
force-pushed
the
bugfix/multicast-sdp-ttl
branch
from
August 18, 2026 11:04
f405a7f to
cbb8667
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the zero-TTL behavior reported by @souravpaul98 when a caps-only
nmossinkstarts with the unspecified0.0.0.0destination and IS-05 later assigns a multicast address.Test plan
cargo fmt -p gst-nmos-rs -- --checkcargo test -p gst-nmos-rs --libcargo test -p gst-nmos-rs --lib -- --test-threads=1c=IN IP4 0.0.0.0to multicast and verify/transportfilecontains/32