Skip to content

Nemo Curator entry#71

Open
abhinavg4 wants to merge 1 commit into
NVIDIA:mainfrom
abhinavg4:wip_ab/nemo-curator
Open

Nemo Curator entry#71
abhinavg4 wants to merge 1 commit into
NVIDIA:mainfrom
abhinavg4:wip_ab/nemo-curator

Conversation

@abhinavg4

@abhinavg4 abhinavg4 commented May 21, 2026

Copy link
Copy Markdown

Onboarding type

  • New product onboarding (new components.d/<slug>.yml file)
  • Other (catalog change, README fix, infrastructure, etc.)

For new product onboarding — author affirmations

By submitting this PR, I confirm on behalf of my team:

  • Skills cleared for open source release per NVIDIA's internal IP review process (six-question check, all answers affirmative)
  • License selected: Apache 2.0 / CC-BY 4.0 / Dual (Apache 2.0 + CC-BY 4.0). Specify: _____
  • No new license or new third-party component introduced beyond what the source repo already carries
  • Source repo is public and under an NVIDIA-owned GitHub org
  • .agents/skills/ or skills/ path used for new entries (or existing path retained for legacy entries per components.d/<slug>.yml)

NVIDIA contributors: see the internal onboarding guide for the IP review process details and license selection.

Reviewer checklist (OSS Skills PIC)

  • Author confirmations above are checked
  • components.d/<slug>.yml entry valid (required fields, unique catalog_dir, path exists in source repo, filename slug matches name)
  • SKILL.md frontmatter spec-compliant (at least one sampled)
  • No new license or third-party dependency requiring OSRB filing

All PRs

  • All commits signed off with DCO (git commit -s).
    If you forgot, run git rebase --signoff origin/main && git push --force-with-lease to retroactively sign all commits in your branch.

Other context (for non-onboarding PRs)

Signed-off-by: Abhinav Garg <abhinavg@stanford.edu>
@abhinavg4 abhinavg4 force-pushed the wip_ab/nemo-curator branch from 5ba77be to 91f2b1e Compare May 21, 2026 18:27
@abhinavg4

Copy link
Copy Markdown
Author

/nvskills-ci

@mosheabr mosheabr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abhinavg4. A few things to resolve before this can go in:

  1. Author affirmations — none of the five onboarding checkboxes (IP review, license, no-new-component, public NVIDIA-org repo, path) are ticked. Please complete them.
  2. Layout — the entry uses the legacy whole-directory sweep form (path: .claude/skills/ + a single product-level catalog_dir: NeMo-Curator). The current standard is one entry per skill: path: skills/<skill-name>/ + catalog_dir: <skill-name>, with product-prefixed names (e.g. nemo-curator-<skill>) so each top-level name is globally unique. Also please use skills/ (or .agents/skills/) rather than the agent-specific .claude/skills/ path.
  3. DCO sign-off email — the commit is Signed-off-by: abhinavg@stanford.edu, but the author email is abhgarg@nvidia.com. Please re-sign with your NVIDIA email (git rebase --signoff after fixing git config user.email) so DCO and author affiliation line up.

Once it's reflowed to per-skill entries with the affirmations ticked and DCO fixed, I'll re-review.

@mosheabr

Copy link
Copy Markdown
Collaborator

Follow-up to the items above — a few more gaps surfaced when checking the source repo (NVIDIA-NeMo/Curator, public/Apache-2.0 ✅), so capturing them here so there's one complete list:

  1. Path is agent-specific. The entry points at .claude/skills/. New entries should use the canonical skills/ (or .agents/skills/) path rather than an agent-specific directory.
  2. Signing + release artifacts missing on the source skills. The skills under that path (getting-started, nemo-curator-docs) currently ship only SKILL.md. Each catalog-bound skill needs skill.oms.sig, a skill card (skill-card.md / SKILLCARD.yaml), and an evals/evals.json alongside SKILL.md in the source repo. Re-running the signing/CI flow on a fresh PR will generate the signature, skill card, and BENCHMARK.md.
  3. Naming/layout (ties to item 2). With the flat catalog layout, use one entry per skill — path: skills/<skill-name>/ + catalog_dir: <skill-name> — and product-prefix the names so they're globally unique (e.g. nemo-curator-...), lowercase. The single whole-directory sweep + capitalized catalog_dir: NeMo-Curator is the legacy pattern.
  4. Nit: add a trailing newline at end of the .yml.

Happy to pair on the layout rewrite if useful. Items 1–2 above plus 4 (signing/evals) are the hard blockers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants