Apply default bash preamble without wrapper - #212
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
fallintoplace
requested review from
alec-flowers,
csahithi,
ishandhanani and
nlevin-ui
as code owners
June 10, 2026 22:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply the cluster-wide
default_bash_preambleeven when a call site passesuse_bash_wrapper=Falseby wrapping that command inbash -conly when the cluster preamble is configured. This keeps nginx and other pre-wrapped commands from silently skipping cluster defaults such as nofile limits.Fixes #107.
Tests
uv run pytest tests/test_slurm.py -quv run ruff check src/srtctl/core/slurm.py src/srtctl/core/schema.py src/srtctl/cli/mixins/frontend_stage.py tests/test_slurm.pyuv run pytest tests -q