fix(profiling): use Dynamo control/ engine routes for start/stop_profile - #264
Open
shyeh25 wants to merge 1 commit into
Open
fix(profiling): use Dynamo control/ engine routes for start/stop_profile#264shyeh25 wants to merge 1 commit into
shyeh25 wants to merge 1 commit into
Conversation
Dynamo moved its control-plane engine routes under a control/ namespace in ai-dynamo/dynamo#10347 (e6fd808c0f, 2026-06-15): - register_engine_route("start_profile", ...) + register_engine_route("control/start_profile", ...) So any Dynamo build ≥ #10347 serves the profiler-trigger at /engine/control/start_profile (and /engine/control/stop_profile), not the old /engine/start_profile. srt-slurm's profiling client (lib/profiling.sh) was still POSTing the old paths. Against a current Dynamo this silently 404s → the profiler is never armed → prefill/decode nsys (and torch) profiles come out empty. There's no error surfaced because the call is best-effort (curl -f ... || Warning). This patch points the dynamo frontend branch at the new control/ routes. Scope / safety: - Only affects the dynamo frontend profiling path (any backend behind it: sglang, vllm). The sglang native-frontend branch (/start_profile) is unchanged. - TRT-LLM is unaffected (it profiles via TLLM_PROFILE_START_STOP, no HTTP call). - No effect on non-profiling runs — this code only runs when profiling: is enabled. - Requires Dynamo ≥ #10347. Older Dynamo served /engine/start_profile; pairing this with a pre-#10347 Dynamo would 404. In practice any Dynamo new enough to also carry the sglang ProfileReq body fix (ai-dynamo/dynamo#11199, 2026-07-06) is already ≥ #10347, so the two go together.
shyeh25
requested review from
alec-flowers,
csahithi,
ishandhanani and
nlevin-ui
as code owners
July 14, 2026 08:04
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage ? 67.21%
=======================================
Files ? 69
Lines ? 9040
Branches ? 0
=======================================
Hits ? 6076
Misses ? 2964
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamo moved its control-plane engine routes under a control/ namespace in ai-dynamo/dynamo#10347 (e6fd808c0f, 2026-06-15):
So any Dynamo build ≥ #10347 serves the profiler-trigger at /engine/control/start_profile (and /engine/control/stop_profile), not the old /engine/start_profile.
srt-slurm's profiling client (lib/profiling.sh) was still POSTing the old paths. Against a current Dynamo this silently 404s → the profiler is never armed → prefill/decode nsys
(and torch) profiles come out empty. There's no error surfaced because the call is best-effort (curl -f ... || Warning).
This patch points the dynamo frontend branch at the new control/ routes.
Scope / safety: