Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace URL query with payload in HTTP request #10

Merged
merged 1 commit into from
Oct 19, 2024
Merged

replace URL query with payload in HTTP request #10

merged 1 commit into from
Oct 19, 2024

Conversation

dmitsh
Copy link
Collaborator

@dmitsh dmitsh commented Oct 18, 2024

This PR is a step one in adding support for block topology.
In this PR we replace the use of URL query in HTTP request for specifying provider and engine with the use of payload.
We also change the structure of the payload to contain provider credentials and engine parameters.
A sample payload will look like that:

{
  "provider": {
    "name": "aws",
	"creds": {
      "access_key_id": "id",
      "secret_access_key": "secret"
    }
  },
  "engine": {
    "name": "slurm",
	"params": {
	  "plugin": "topology/block",
	  "block_sizes": "30,120"
	}
  },
  "nodes": [
    {
      "region": "region1",
      "instances": {
        "instance1": "node1",
        "instance2": "node2",
        "instance3": "node3"
      }
    },
    {
      "region": "region2",
      "instances": {
        "instance4": "node4",
        "instance5": "node5",
        "instance6": "node6"
      }
    }
  ]
}

@dmitsh dmitsh force-pushed the ds-api branch 6 times, most recently from 6a0555f to 9d999c3 Compare October 19, 2024 07:08
Signed-off-by: Dmitry Shmulevich <[email protected]>
@dmitsh dmitsh changed the title replace URL query with URL payload replace URL query with payload in HTTP request Oct 19, 2024
@dmitsh dmitsh merged commit b7d5a58 into main Oct 19, 2024
4 checks passed
@dmitsh dmitsh deleted the ds-api branch October 19, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants