Skip to content

expand dbt usage in FacDB#2388

Merged
damonmcc merged 2 commits into
mainfrom
dm-facdb-refactor
May 27, 2026
Merged

expand dbt usage in FacDB#2388
damonmcc merged 2 commits into
mainfrom
dm-facdb-refactor

Conversation

@damonmcc
Copy link
Copy Markdown
Member

@damonmcc damonmcc commented May 21, 2026

related to #2386

  • Replaced _create_facdb_agency.sql and _create_facdb_classification.sql with dbt seed models and intermediate models (facdb_agency, facdb_classification)
  • Added lookup_factype.csv as a new dbt seed
  • Added staging/sources.yml to declare upstream sources
  • Updated cli.py to invoke dbt instead of the old SQL scripts

confirm outputs don't change

used the s3_compare notebook to compare this branch's outputs to nightly_qa. all files are virtually identical

Screenshot 2026-05-27 at 4 40 36 PM

qc_classification.csv show facsubgrp counts and they're identical

Screenshot 2026-05-27 at 4 43 08 PM

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.69%. Comparing base (5b0d9bb) to head (8116354).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@damonmcc damonmcc force-pushed the dm-facdb-refactor branch from 3adb96d to 8116354 Compare May 27, 2026 17:19
@damonmcc damonmcc marked this pull request as ready for review May 27, 2026 21:02
@damonmcc damonmcc merged commit d82382d into main May 27, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant