You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 5, 2024. It is now read-only.
Currently the extension does not update the title on new windows after initialization completed, leading to a weird behavior - the toggles are not applied until one got changed. That means when you open a new window, you'd have to toggle off then on again for the original setting to remain.
This PR fixes it by calling updateTitlePrefixes on every window opened so settings will be applied.
I'm rewriting this extension from scratch. My version doesn't have this problem
When I finish this, I'll upload the new version as an update to the old one. This repo will be archived later, since it's a fork. I wrote the new version myself, so it's in the new repository
I'm rewriting this extension from scratch. My version doesn't have this problem
When I finish this, I'll upload the new version as an update to the old one. This repo will be archived later, since it's a fork. I wrote the new version myself, so it's in the new repository
Glad to know that :) I did this patch just because I was a bit annoyed by the issue 😅
Looking forward to the new version!
Also the firefox userchrome you created has been a great experience, thank you for that as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the extension does not update the title on new windows after initialization completed, leading to a weird behavior - the toggles are not applied until one got changed. That means when you open a new window, you'd have to toggle off then on again for the original setting to remain.
This PR fixes it by calling
updateTitlePrefixeson every window opened so settings will be applied.