Skip to content

Conversation

JBlocks
Copy link
Contributor

@JBlocks JBlocks commented Aug 14, 2019

The precompile backend action (system toolbar) is now compatible with the request and response interface

@NamelessCoder
Copy link
Owner

This changes the TYPO3 compatibility of the extension and shouldn't enable strict types or declare strict returns. AFAIK it is possible to have compatible signatures for both v9 and v8 LTS versions.

@JBlocks
Copy link
Contributor Author

JBlocks commented Aug 14, 2019

This changes the TYPO3 compatibility of the extension and shouldn't enable strict types or declare strict returns. AFAIK it is possible to have compatible signatures for both v9 and v8 LTS versions.

Okay. Removed the declare(strict_types=1);, strict return type and added parameter signature null to get compatible with version 8. Version 8 has no middleware and no request and response interface as method signature. So we have $request = null and $response = null in version 8. I'm totally fine with this implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants