fix(core): sync platform-scoped test helpers - #11
Merged
Conversation
Sync TokenBar 729dc3ad into the Windows vendored core so the Copilot Desktop mtime helper import follows its Unix-only test and the four Kiro globalStorage fixture helpers follow their macOS-only tests. Keep the Windows shared-tree local patch table empty and update SYNC.md to pin the exact Native merge commit, describe the test-only behavior, and record the reproduced parity and verification boundary. Cargo.lock, runtime code, parser output, cache formats, C ABI, and fixtures remain unchanged. Verified with byte-and-mode parity across crates and shared vendor paths, matching C header and provider-v3 fixtures, Rust 1.96.1 strict core Clippy, the full scripts/check.sh gate, native Windows x64 strict Clippy evidence, and a fresh verifier. The full gate passed 319 FFI tests, 1290 core tests with one ignored, integrations 10/1/3/1, release build, .NET build with zero warnings/errors, 287 Core tests, and P/Invoke smoke.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
729dc3adplatform cfg cleanupBehavior
The Copilot Desktop mtime helper import now follows its existing Unix-only test, and four Kiro globalStorage fixture helpers follow their existing macOS-only tests. This removes Windows Rust 1.96.1 all-targets Clippy unused/dead-code failures without changing runtime code or test bodies.
Verification
crates/andvendor/byte/mode parity with Native, excluding only Nativevendor/AGENTS.mdand WindowsSYNC.mdCargo.lockunchangedscripts/check.sh: 319 FFI; 1290 core + 1 ignored; integrations 10/1/3/1; release build; .NET build 0 warnings/errors; 287 Core tests; P/Invoke smokeCONFIRMEDHosted Windows x64 and ARM64 cross-package checks remain CI-owned; this PR does not claim real ARM64 runtime verification.