Skip to content

Dunn Index #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Dunn Index #170

wants to merge 5 commits into from

Conversation

pratikwatwani
Copy link

@pratikwatwani pratikwatwani commented Dec 29, 2024

Added a new section for Dunn Index (Clustering) metric

cc @santiviquez

Added a new section for Dunn Index (Clustering) metric
@santiviquez
Copy link
Collaborator

santiviquez commented Jan 9, 2025

Hi @pratikwatwani sorry for the delay. I was checking the PR but looks like the image Dunn_Index_Visualized.png was not added in the commit.

@santiviquez
Copy link
Collaborator

Hi @pratikwatwani just following up on the last message. Do you have the image Dunn_Index_Visualized.png it was not added in the commit.

@pratikwatwani
Copy link
Author

Hi @santiviquez, not sure how it was not in the repo. I have attached it here for your ref
Dunn_Index_Visualized

@santiviquez
Copy link
Collaborator

@pratikwatwani cool thanks! Do you have the code that created the plot? If so, could you create a notebook called clustering_plots.ipynb inside the notebooks/ directory and add the code there?

@pratikwatwani
Copy link
Author

@santiviquez updated all files, added a jupyter notebook and visualization file.

@pratikwatwani
Copy link
Author

hey @santiviquez what do you think? if this looks good, I can work on the rest, let me know!

@santiviquez
Copy link
Collaborator

Hi @pratikwatwani, I finally had a chance to compile your contribution, but it looks like there are several issues with the formula layout. Additionally, the metric description seems too verbose. Ideally, we should present all the theoretical aspects of the metric on the first page. Check out the third image for a good example.

Screenshot 2025-03-03 at 19 01 27 Screenshot 2025-03-03 at 19 01 36

Nice first page layout.
Screenshot 2025-03-03 at 19 04 07

@pratikwatwani
Copy link
Author

@santiviquez thanks for the feedback! Let me fix that. Also, are we restricting content to a single page for each metric?

@santiviquez
Copy link
Collaborator

Hi @pratikwatwani thanks for taking a look!

With regard to your questions, no, each metric will have two book pages. The first page is all about the theory and description of the metric, and the second is for visuals and the "did you know" section.

@pratikwatwani
Copy link
Author

@santiviquez thanks for the feedback. I'll restructure this and fix the verbiage. I'll update you in some time!

@pratikwatwani
Copy link
Author

@santiviquez i have updated the page and have attached the screenshot of the output so you can quickly confirm without having to go through compiling process on your end. let me know what you think!
Screenshot 2025-03-09 at 12 04 26 AM
Screenshot 2025-03-09 at 12 04 40 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants