Skip to content

Simplify eslint and prettier #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinFillon merged 5 commits into from
Oct 4, 2025
Merged

Simplify eslint and prettier #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a62117c
chore: migrate to shared ESLint and Prettier configurations, remove p…
Exeloo Oct 1, 2025
4a68c06
chore: remove `pnpm-lock.yaml` to decouple dependency locking from th…
Exeloo Oct 1, 2025
466cecb
chore: migrate packages to shared ESLint and Prettier configs
Exeloo Oct 2, 2025
f6c07d8
chore: remove unnecessary `@types/node` and `typescript` dependencies…
Exeloo Oct 2, 2025
79ce7a7
feat(ci): add build step to GitHub Actions tests workflow
Exeloo Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ jobs:
with:
actions-cache-folder: ${{env.EM_CACHE_FOLDER}}

- name: "Run build"
run: pnpm build

- name: "Run tests"
run: pnpm test:unit

Expand Down
2 changes: 0 additions & 2 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
pnpm lint-staged
pnpm fix
pnpm lint
5 changes: 4 additions & 1 deletion .husky/pre-push
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
pnpm lerna run lint,test:unit
pnpm clean
pnpm lint
pnpm build
pnpm test
11 changes: 0 additions & 11 deletions .prettierrc
View file
Open in desktop

This file was deleted.

46 changes: 2 additions & 44 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,45 +1,3 @@
import pluginJs from "@eslint/js";
import eslintConfigPrettier from "eslint-config-prettier";
import globals from "globals";
import tseslint from "typescript-eslint";
import config from "@nanoforge/utils-eslint-config";

export default [
{ files: ["src/**/*.{ts}"] },
{ languageOptions: { globals: globals.node } },

pluginJs.configs.recommended,
...tseslint.configs.recommended,
...tseslint.configs.strict,
eslintConfigPrettier,
{ ignores: ["**/*.js"] },
{
rules: {
"@typescript-eslint/consistent-type-imports": [
"error",
{
disallowTypeAnnotations: true,
fixStyle: "inline-type-imports",
prefer: "type-imports",
},
],
"@typescript-eslint/no-extraneous-class": "off",
"@typescript-eslint/no-empty-object-type": "off",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/ban-ts-comment": "off",
"@typescript-eslint/member-ordering": [
"error",
{
default: [
"static-field",
"field",
"public-static-method",
"constructor",
"method",
"protected-method",
"private-method",
],
},
],
},
},
];
export default config;
2 changes: 1 addition & 1 deletion example/pong/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default [
...tseslint.configs.recommended,
...tseslint.configs.strict,
eslintConfigPrettier,
{ ignores: ["**/*.js"] },
{ ignores: ["**/*.js", "**/*.d.ts"] },
{
rules: {
"@typescript-eslint/consistent-type-imports": [
Expand Down
3 changes: 2 additions & 1 deletion lerna.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"$schema": "node_modules/lerna/schemas/lerna-schema.json",
"packages": [
"packages/*"
"packages/*",
"utils/*"
],
"version": "0.0.0"
}
22 changes: 5 additions & 17 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,40 +27,28 @@
"test:unit": "lerna run test:unit",
"test:e2e": "lerna run test:e2e",
"prepare": "husky",
"taze": "taze major -w && lerna run taze",
"lint-staged": "lint-staged"
"taze": "taze major -w && lerna run taze"
},
"dependencies": {
"tslib": "^2.8.1"
},
"devDependencies": {
"@commitlint/cli": "^20.0.0",
"@commitlint/config-conventional": "^20.0.0",
"@eslint/js": "^9.36.0",
"@nanoforge/utils-eslint-config": "workspace:^",
"@nanoforge/utils-prettier-config": "workspace:^",
"@trivago/prettier-plugin-sort-imports": "^5.2.2",
"@types/node": "^22.18.7",
"eslint": "^9.36.0",
"eslint-config-prettier": "^10.1.8",
"eslint-plugin-format": "^1.0.2",
"eslint-plugin-prettier": "^5.5.4",
"globals": "^16.4.0",
"husky": "^9.1.7",
"lerna": "^8.2.4",
"lint-staged": "^16.2.3",
"prettier": "^3.6.2",
"taze": "^19.7.0",
"typescript": "^5.9.2",
"typescript-eslint": "^8.45.0"
"typescript": "^5.9.2"
},
"engines": {
"node": "23.6.0",
"pnpm": "10.17.1"
},
"packageManager": "[email protected]",
"lint-staged": {
"**/*.{js,ts}": [
"eslint --fix",
"prettier --write"
]
}
"packageManager": "[email protected]"
}
11 changes: 0 additions & 11 deletions packages/asset-manager/.prettierrc
View file
Open in desktop

This file was deleted.

64 changes: 2 additions & 62 deletions packages/asset-manager/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,63 +1,3 @@
import pluginJs from "@eslint/js";
import eslintConfigPrettier from "eslint-config-prettier";
import globals from "globals";
import tseslint from "typescript-eslint";
import pluginJest from "eslint-plugin-jest";
import config from "@nanoforge/utils-eslint-config";

export default [
{
files: ["src/**/*.{ts}"],
},
{ languageOptions: { globals: globals.node } },


pluginJs.configs.recommended,
...tseslint.configs.recommended,
...tseslint.configs.strict,
eslintConfigPrettier,
{ ignores: ["**/*.js"] },
{
rules: {
"@typescript-eslint/consistent-type-imports": [
"error",
{
disallowTypeAnnotations: true,
fixStyle: "inline-type-imports",
prefer: "type-imports",
},
],
"@typescript-eslint/no-extraneous-class": "off",
"@typescript-eslint/no-empty-object-type": "off",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/ban-ts-comment": "off",
"@typescript-eslint/member-ordering": [
"error",
{
default: [
"static-field",
"field",
"public-static-method",
"constructor",
"method",
"protected-method",
"private-method",
],
},
],
},
},
{
files: ["**/*.spec.ts"],
plugins: { jest: pluginJest },
languageOptions: {
globals: pluginJest.environments.globals.globals,
},
rules: {
"jest/no-disabled-tests": "warn",
"jest/no-focused-tests": "error",
"jest/no-identical-title": "error",
"jest/prefer-to-have-length": "warn",
"jest/valid-expect": "error",
}
}
];
export default config;
26 changes: 4 additions & 22 deletions packages/asset-manager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,42 +29,24 @@
"lint": "eslint . && prettier --check .",
"fix": "eslint . --fix && prettier --write .",
"taze": "taze major -w",
"lint-staged": "lint-staged",
"test:unit": "jest --config ./jest.config.json"
},
"dependencies": {
"@nanoforge/common": "workspace:^"
},
"devDependencies": {
"@commitlint/cli": "^20.0.0",
"@commitlint/config-conventional": "^20.0.0",
"@eslint/js": "^9.36.0",
"@trivago/prettier-plugin-sort-imports": "^5.2.2",
"@nanoforge/utils-eslint-config": "workspace:^",
"@nanoforge/utils-prettier-config": "workspace:^",
"@types/jest": "^30.0.0",
"@types/node": "^22.18.7",
"eslint": "^9.36.0",
"eslint-config-prettier": "^10.1.8",
"eslint-plugin-format": "^1.0.2",
"eslint-plugin-jest": "^29.0.1",
"eslint-plugin-prettier": "^5.5.4",
"globals": "^16.4.0",
"jest": "^30.2.0",
"lint-staged": "^16.2.3",
"prettier": "^3.6.2",
"taze": "^19.7.0",
"ts-jest": "^29.4.4",
"typescript": "^5.9.2",
"typescript-eslint": "^8.45.0"
"typescript": "^5.9.2"
},
"engines": {
"node": "23.6.0",
"pnpm": "10.17.1"
},
"packageManager": "[email protected]",
"lint-staged": {
"**/*.{js,ts}": [
"eslint --fix",
"prettier --write"
]
}
"packageManager": "[email protected]"
}
3 changes: 3 additions & 0 deletions packages/asset-manager/prettier.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import config from "@nanoforge/utils-prettier-config";

export default config;
11 changes: 0 additions & 11 deletions packages/common/.prettierrc
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/common/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
# Engine Core
# Engine Common
46 changes: 2 additions & 44 deletions packages/common/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,45 +1,3 @@
import pluginJs from "@eslint/js";
import eslintConfigPrettier from "eslint-config-prettier";
import globals from "globals";
import tseslint from "typescript-eslint";
import config from "@nanoforge/utils-eslint-config";

export default [
{ files: ["src/**/*.{ts}"] },
{ languageOptions: { globals: globals.node } },

pluginJs.configs.recommended,
...tseslint.configs.recommended,
...tseslint.configs.strict,
eslintConfigPrettier,
{ ignores: ['**/*.js'] },
{
rules: {
"@typescript-eslint/consistent-type-imports": [
"error",
{
disallowTypeAnnotations: true,
fixStyle: "inline-type-imports",
prefer: "type-imports",
},
],
"@typescript-eslint/no-extraneous-class": "off",
"@typescript-eslint/no-empty-object-type": "off",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/ban-ts-comment": "off",
"@typescript-eslint/member-ordering": [
"error",
{
default: [
"static-field",
"field",
"public-static-method",
"constructor",
"method",
"protected-method",
"private-method",
],
},
],
},
},
];
export default config;
27 changes: 5 additions & 22 deletions packages/common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,33 +28,16 @@
"clean:scripts": "find src -name '*.js' -delete",
"lint": "eslint . && prettier --check .",
"fix": "eslint . --fix && prettier --write .",
"taze": "taze major -w",
"lint-staged": "lint-staged"
"taze": "taze major -w"
},
"devDependencies": {
"@commitlint/cli": "^20.0.0",
"@commitlint/config-conventional": "^20.0.0",
"@eslint/js": "^9.36.0",
"@trivago/prettier-plugin-sort-imports": "^5.2.2",
"eslint": "^9.36.0",
"eslint-config-prettier": "^10.1.8",
"eslint-plugin-format": "^1.0.2",
"eslint-plugin-prettier": "^5.5.4",
"globals": "^16.4.0",
"lint-staged": "^16.2.3",
"prettier": "^3.6.2",
"taze": "^19.7.0",
"typescript-eslint": "^8.45.0"
"@nanoforge/utils-eslint-config": "workspace:^",
"@nanoforge/utils-prettier-config": "workspace:^",
"taze": "^19.7.0"
},
"engines": {
"node": "23.6.0",
"pnpm": "10.17.1"
},
"packageManager": "[email protected]",
"lint-staged": {
"**/*.{js,ts}": [
"eslint --fix",
"prettier --write"
]
}
"packageManager": "[email protected]"
}
3 changes: 3 additions & 0 deletions packages/common/prettier.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import config from "@nanoforge/utils-prettier-config";

export default config;
11 changes: 0 additions & 11 deletions packages/config/.prettierrc
View file
Open in desktop

This file was deleted.

Loading
Loading