parts of thfeat(studio): improve truth files filtering and UI feedback#177
Open
justlovemaki wants to merge 1 commit intoNarcooo:masterfrom
Open
parts of thfeat(studio): improve truth files filtering and UI feedback#177justlovemaki wants to merge 1 commit intoNarcooo:masterfrom
justlovemaki wants to merge 1 commit intoNarcooo:masterfrom
Conversation
- Update API to filter story files using TRUTH_FILES constant - Add loading and error states to the TruthFiles content viewer - Reset edit mode and prevent stale content display when switching files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TRUTH_FILESconstant.Type of change
Motivation (optional)
To ensure the Truth Files feature only displays supported markdown/JSON files and provides a smoother user experience with proper loading/error indicators.
Changes
TRUTH_FILESconstant.useApi, and added state reset logic inhandleSelect.Test plan
pnpm typecheckpassespnpm testpasses