Skip to content

Add accessory wind extraction pieces#315

Merged
ppinchuk merged 33 commits into
mainfrom
pp/dwind
Oct 28, 2025
Merged

Add accessory wind extraction pieces#315
ppinchuk merged 33 commits into
mainfrom
pp/dwind

Conversation

@ppinchuk
Copy link
Copy Markdown
Collaborator

Very heavily based on utility-wind extraction

@ppinchuk ppinchuk added this to the New technologies milestone Oct 27, 2025
@ppinchuk ppinchuk self-assigned this Oct 27, 2025
@ppinchuk ppinchuk requested a review from castelao as a code owner October 27, 2025 17:31
@ppinchuk ppinchuk added enhancement Update to logic or general code improvements new computation Update that adds a new computation method topic-python-llm Issues/pull requests related to LLMs labels Oct 27, 2025
@ppinchuk
Copy link
Copy Markdown
Collaborator Author

@castelao This is ready for review. A big PR so you don't need to go into details but maybe glancing at the GHA filer and the docs updates would be good

Copy link
Copy Markdown
Member

@castelao castelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on this review but wanted to share a thought before finishing it. For the edge case that we discussed today, would a simple pixi -e <env> install would resolve the issue? Even with the cache and not touching pyproject.toml, would it 're-install' COMPASS since it is in editable mode?

Comment thread .github/workflows/ci-python.yml
Comment thread .github/workflows/ci-python.yml
@ppinchuk
Copy link
Copy Markdown
Collaborator Author

I'm working on this review but wanted to share a thought before finishing it. For the edge case that we discussed today, would a simple pixi -e <env> install would resolve the issue? Even with the cache and not touching pyproject.toml, would it 're-install' COMPASS since it is in editable mode?

Yea actually that's a good idea. I will go ahead and add that

Comment thread pyproject.toml
@ppinchuk ppinchuk merged commit 16842b7 into main Oct 28, 2025
13 checks passed
@ppinchuk ppinchuk deleted the pp/dwind branch October 28, 2025 15:55
rajeee pushed a commit that referenced this pull request May 27, 2026
* Update docstrings

* Add distributed wind ordinance file

* Add `__init__.py`

* Add first pass of graphs for d wind

* Move system size reminder to be technology-specific

* Rename variable

* Update name

* Add initial version of parsing for dwind

* Remove unused keys

* Fix system size prompt

* ANother fix for system size

* Fix import

* Update example

* System size fix

* No need for primary or special use districts for dwind

* Add max turbine height clarifications

* Add clarification about participating owners

* Add clarification about costs

* Add tower density for DWind

* Rename classes

* Rename module

* Add "accessory wind" as tech

* Try to fix tests

* Cache only on main branch

* Don't cache on branch

* Update lockfile

* Guard Python in the rdev env

* Run locked tests specifically

* Add release instructions

* Add install command to GHA

* Bump elm dep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Update to logic or general code improvements new computation Update that adds a new computation method topic-python-llm Issues/pull requests related to LLMs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants